Re: biology/openbabel seems to require lower gcc version

[Jason Bacon <outpaddling%yahoo.com@localhost>]

On 2019-04-17 20:49, Mayuresh wrote:
> On Wed, Apr 17, 2019 at 07:47:20AM -0500, Jason Bacon wrote:
> > The current package version, 2.3.2 dates to Oct 2012.  Have you considered
> > upgrading the package to the latest release instead?
> Makes sense. Yes, the upgrade works.
>
> I did not use the old patches which appear to try to make do with older
> compilers. It might get harder to maintain them as the code becomes
> dependent on more recent compilers (as we already saw here).
>
> If someone could confirm whether it is alright to expunge the patches, I
> can submit a patch for upgrade.
>
> Only one of the patches isn't related to gcc version. It looks like this:
>
> -install(FILES ${man_1} DESTINATION share/man/man1)
> +install(FILES ${man_1} DESTINATION ${CMAKE_INSTALL_MANDIR}/man1)
>
> Curious about the need of this patch.
>
> Mayuresh
Looks like CMAKE_INSTALL_MANDIR  is provided by pkgsrc, so the patch is 
about respecting the pkgsrc env.

Linux centosdev.ceas  bacon ~ 1002: fgrep -r CMAKE_INSTALL /usr/pkgsrc/mk/
/usr/pkgsrc/mk/cmake-Modules/Platform/UnixPaths.cmake:GET_FILENAME_COMPONENT(_CMAKE_INSTALL_DIR 
"${CMAKE_ROOT}" PATH)
/usr/pkgsrc/mk/cmake-Modules/Platform/UnixPaths.cmake:GET_FILENAME_COMPONENT(_CMAKE_INSTALL_DIR 
"${_CMAKE_INSTALL_DIR}" PATH)
/usr/pkgsrc/mk/configure/cmake.mk:# CMAKE_INSTALL_PREFIX
/usr/pkgsrc/mk/configure/cmake.mk:CMAKE_INSTALL_PREFIX?= ${PREFIX}
/usr/pkgsrc/mk/configure/cmake.mk:CMAKE_ARGS+= 
-DCMAKE_INSTALL_PREFIX:PATH=${CMAKE_INSTALL_PREFIX}
/usr/pkgsrc/mk/configure/cmake.mk:CMAKE_ARGS+= 
-DCMAKE_INSTALL_NAME_DIR:PATH=${PREFIX}/lib
/usr/pkgsrc/mk/configure/cmake.mk:CMAKE_ARGS+= 
-DCMAKE_INSTALL_LIBDIR:PATH=lib
/usr/pkgsrc/mk/configure/cmake.mk:CMAKE_ARGS+= 
-DCMAKE_INSTALL_MANDIR:PATH=${PKGMANDIR}
/usr/pkgsrc/mk/configure/cmake.mk:CMAKE_ARGS+= 
-DCMAKE_INSTALL_INFODIR:PATH=${PKGINFODIR}
/usr/pkgsrc/mk/configure/cmake.mk:CMAKE_ARGS+= 
-DCMAKE_INSTALL_LOCALEDIR:PATH=${PKGLOCALEDIR}/locale

I'm all for removing other unnecessary patches.  Is this looking for a 
compiler newer than the year 2011??

+#if defined(_MSC_VER) || defined(_LIBCPP_VERSION) || __cplusplus>=201103L

If you drop your upgraded package in wip, I'll test it on my dev servers 
and report any issues.

Cheers,

    JB