Re: github

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Hello Patrick and Thomas,

Thomas Klausner writes:
> On Mon, Jul 30, 2018 at 05:37:27PM +0100, Patrick Welche wrote:
> > Given
> > 
> > DISTNAME=       imageio-2.3.0
> > PKGNAME=        ${PYPKGPREFIX}-${DISTNAME}
> > CATEGORIES=     graphics python
> > MASTER_SITES=   ${MASTER_SITE_GITHUB:=imageio/}
> > GITHUB_TAG=     v${PKGVERSION_NOREV}
> > 
> > I'm surprised to see PYPKGPREFIX appearing in the download url:
> > 
> > Requesting https://github.com/imageio/py36-imageio/archive/v2.3.0.tar.gz
> > ftp: Error retrieving file `404 Not Found'
>
> For some reason GITHUB_PROJECT is set using PKGNAME (I don't know why).
> Set it manually, that should work.

Yes, by default it is ${PKGBASE}, probably Tobias will shed some light
regarding the rationale, but at least, most of the time it does the
trick (except when it doesn't^W^W^Wfor Python packages! :))

Not strictly related to the question but probably pretty helpful
to avoid GitHub headaches, `show-all-github' target, e.g.:

 | % cd pkgsrc/devel/py-usb
 | % make show-all-github
 | github:
 |   pkg   GITHUB_PROJECT = pyusb
 |   pkg   GITHUB_TAG = 1.0.0
 |   pkg   GITHUB_TYPE = tag
 |   def   _USE_GITHUB = YES
 |   def   _GITHUB_DEFAULT_DISTFILES = pyusb-1.0.0.tar.gz
 |   def   SITES.pyusb-1.0.0.tar.gz = -https://github.com/pyusb/pyusb/archive/1.0.0.tar.gz
 |