Re: lang/vim crashes when build on ubuntu

[Aleksej Lebedev <root%zta.lk@localhost>]

On 2018-04-06 15:10, Aleksej Lebedev wrote:
> Hi, everyone!
>
> For quite some time ubuntu is shipping gcc with _FORTIFY_SOURCE=2
> defined by default.
> This makes vim crash.
>
> Here is the discussion:
> https://groups.google.com/forum/#!msg/vim_dev/HU5aZfCv4iM/aHZlX67jcsEJ
>
> I encountered it first time in ubuntu-18.04, but root cause is known
> for quite a while.
>
> I am not quite sure what would be the best way to pass
> _FORTIFY_SOURCE=1 from pkgsrc.
> So I am not providing the patch yet. But maybe it's immediately clear
> for morr%NetBSD.org@localhost ;-).

This patch fixes the problem:

$ sudo /pkg/bin/cvs diff editors/vim-share
cvs diff: Diffing editors/vim-share
Index: editors/vim-share/Makefile.common
===================================================================
RCS file: /cvsroot/pkgsrc/editors/vim-share/Makefile.common,v
retrieving revision 1.160
diff -r1.160 Makefile.common
42a43
> CONFIGURE_ARGS+=	CFLAGS=-D_FORTIFY_SOURCE=1
cvs diff: Diffing editors/vim-share/patches

... but it's not completely correct since it triggers
lots of warnings like that:
<command-line>:0:0: warning: "_FORTIFY_SOURCE" redefined
<command-line>:0:0: note: this is the location of the previous 
definition

--
Aleksej Lebedev