Re: Regressions in libgphoto2 and audacity.

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Sat, Mar 31, 2018 at 03:34:09PM -0500, John D. Baker wrote:
> On Thu, 29 Mar 2018, John D. Baker wrote:
> 
> > Two, however, are reflected in recent bulk builds, notably "libgphoto2"
> > and "audacity" as see in:
> > 
> >   http://mail-index.netbsd.org/pkgsrc-bulk/2018/03/26/msg015770.html
> 
> The "libgphoto2" problem appears to be a matter of adjusting the PLIST:
> 
> +Index: devel/libgphoto2/PLIST.common
> +RCS file: /cvsroot/pkgsrc/devel/libgphoto2/PLIST.common,v
> +--- devel/libgphoto2/PLIST.common	5 Oct 2015 04:47:02 -0000	1.22
> ++++ devel/libgphoto2/PLIST.common	31 Mar 2018 20:20:11 -0000
> +@@ -89,7 +89,9 @@ lib/libgphoto2_port.la
> + lib/libgphoto2_port/0.12.0/disk.la
> + lib/libgphoto2_port/0.12.0/ptpip.la
> + lib/libgphoto2_port/0.12.0/serial.la
> +-${PLIST.libusb}lib/libgphoto2_port/0.12.0/usb.la
> ++${PLIST.libusb}lib/libgphoto2_port/0.12.0/usb1.a
> ++${PLIST.libusb}lib/libgphoto2_port/0.12.0/usb1.la
> ++${PLIST.libusb}lib/libgphoto2_port/0.12.0/usb1.so

The .la line is enough. It will be expanded via the
libtool-PLIST-magic to include the other entries.

> + ${PLIST.libusb}lib/libgphoto2_port/0.12.0/usbdiskdirect.la
> + ${PLIST.libusb}lib/libgphoto2_port/0.12.0/usbscsi.la
> + lib/pkgconfig/libgphoto2.pc
> 
> I'm not sure about the "usb1.a" and "usb1.so" files, but those were in
> the group about which it complained they were in the .destdir but not
> in the PLIST.
> 
> Not sure how this should be done to support the LIBUSB_TYPE=native
> option, should one wish it.

I've switched the package to use libusb1, that should fix it consistently.

Thanks,
 Thomas