pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: digest pkglint-compliant

Not really - why do we have to put ${RUN} before every command in package Makefiles now?

FYI - the ${_PKG_SILENT}${_PKG_DEBUG} sequence was introduced to debug the infrastructure, and it's fairly good, if verbose, at doing that

Frankly, if one has trouble seeing what's going on with digest's Makefile shell commands, then there are going to be lots of harder challenges in the next few days and weeks

Even if that were not the case, the digest package is the one that deserves the least cosmetic churn, since everything else uses it

And, finally, even if all the rest were true, now is not a good time to do it


On 23 March 2018 at 00:27, Frédéric Fauberteau <> wrote:
Hi agc@,

Do you agree the following changes to make pkgtools/digest looking fine according to pkglint?

Index: Makefile
RCS file: /cvsroot/pkgsrc/pkgtools/digest/Makefile,v
retrieving revision 1.61
diff -u -r1.61 Makefile
--- Makefile    9 Oct 2014 14:06:49 -0000       1.61
+++ Makefile    23 Mar 2018 07:21:32 -0000
@@ -21,14 +21,14 @@

-       @${CP} -R ${FILESDIR} ${WRKSRC}
+       ${RUN} ${CP} -R ${FILESDIR} ${WRKSRC}

-       -@${MKDIR} ${DESTDIR}${PKG_DBDIR}
+       ${RUN} ${MKDIR} ${DESTDIR}${PKG_DBDIR} || ${TRUE}

-       @${ECHO} "No news is good news"
-       @cd ${WRKSRC} && ${SETENV} DIGESTDIR=${WRKSRC} ${SH} ./
-       @${ECHO} "All tests completed"
+       ${RUN} ${ECHO} "No news is good news"
+       ${RUN} cd ${WRKSRC} && ${SETENV} DIGESTDIR=${WRKSRC} ${SH} ./
+       ${RUN} ${ECHO} "All tests completed"

 .include "../../mk/"
Index: distinfo
RCS file: distinfo
diff -N distinfo
--- /dev/null   1 Jan 1970 00:00:00 -0000
+++ distinfo    23 Mar 2018 07:21:32 -0000
@@ -0,0 +1 @@

Home | Main Index | Thread Index | Old Index