Re: lang/ruby2{2,3,4}-base fail PLIST file-check on Darwin

["J. Lewis Muir" <jlmuir%imca-cat.org@localhost>]

On 06/29, Min Sik Kim wrote:
> On Jun 29, 2017, at 12:52, J. Lewis Muir <jlmuir%imca-cat.org@localhost> wrote:
> > 
> > Building -current from a day ago on Darwin (macOS Sierra 10.12.5) using
> > pkg_comp (which uses pbulk), lang/ruby22-base, lang/ruby23-base, and
> > lang/ruby24-base all fail due to a PLIST mismatch as shown below.
> > 
> > ========== lang/ruby22-base ==========
> > => Checking file-check results for ruby22-base-2.2.7
> > ERROR: ************************************************************
> > ERROR: The following files are in the PLIST but not in /pkg_comp/work/pkg/lang/ruby22-base/work/.destdir/opt/pkg:
> > ERROR:         /pkg_comp/work/pkg/lang/ruby22-base/work/.destdir/opt/pkg/lib/libruby22.-static.a
> > ERROR: ************************************************************
> > ERROR: The following files are in /pkg_comp/work/pkg/lang/ruby22-base/work/.destdir/opt/pkg but not in the PLIST:
> > ERROR:         /pkg_comp/work/pkg/lang/ruby22-base/work/.destdir/opt/pkg/lib/libruby22.2.2.0-static.a
> > *** Error code 1
> > ======================================
> 
> Does the patch below fix it?

Hello, Min!

Yes, it does!  Thank you!

BTW, I noticed something else suspicious in lang/ruby/rubyversion.mk on
line 538, in the PLIST_SUBST assignment:

  RUBY_SHLIBI_VERSION=${RUBY_SHLIB_VERSION:Q} RUBY_ARCH=${RUBY_ARCH:Q}
            ^
  Is that "I" supposed to be there?  Looks like a typo.

On top of that, is RUBY_SHLIB_VERSION set to anything?  Obviously it
wasn't for Darwin in light of this build issue and your patch, and I
can't find a reference to it anywhere.  So, maybe this line should just
go away entirely?

Regards,

Lewis

> diff --git a/lang/ruby/rubyversion.mk b/lang/ruby/rubyversion.mk
> index a8a7ccc67cf..3ec108de548 100644
> --- a/lang/ruby/rubyversion.mk
> +++ b/lang/ruby/rubyversion.mk
> @@ -413,7 +413,7 @@ RUBY_SHLIBVER=		${_RUBY_VER_MAJOR}.${_RUBY_VER_MINOR}${_RUBY_SHLIB_MINOR}
>  .elif ${OPSYS} == "Darwin"
>  RUBY_SHLIB=		${RUBY_SUFFIX}.${RUBY_SHLIBVER}.${RUBY_SLEXT}
>  _RUBY_SHLIBALIAS=	.${_RUBY_VER_MAJOR}.${_RUBY_VER_MINOR}.${RUBY_SLEXT}
> -RUBY_STATICLIB=		${RUBY_SUFFIX}.${RUBY_SHLIB_VERSION}-static.a
> +RUBY_STATICLIB=		${RUBY_SUFFIX}.${RUBY_SHLIBVER}-static.a
>  .elif ${OPSYS} == "Linux"
>  _RUBY_SHLIBALIAS=	${RUBY_SUFFIX}.${RUBY_SLEXT}.${_RUBY_VER_MAJOR}.${_RUBY_VER_MINOR}
>  .elif ${OPSYS} == "SunOS"
>