Re: Please review wip/cd-hit and wip/bwa

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Mon, Sep 28, 2015 at 01:30:36PM -0500, Jason Bacon wrote:
> Both should be about ready to commit.

cd-hit:

Please take a look at mk/fetch/github.mk - I think MASTER_SITES and
perhaps PKGNAME/DISTNAME can be simplified.

SUBST_*: I think the destdir one can be replaced with MAKE_FLAGS+=
PREFIX=${DESTDIR}${PREFIX} or similar.

FETCH_USING is a user-settable variable and shouldn't be in a pkgsrc
Makefile. Set it in /etc/mk.conf if your ftp(1) doesn't support https.

Shouldn't this depend on perl if it installs perl scripts?

There is no point in a bl3.mk file since this package does not provide
libraries or headers.

bwa:

No bl3.mk needed.


Cheers,
 Thomas