Re: [patch] fix for building archivers/zoo

[Matthias Ferdinand <mf+ml.pkgsrc-users%netzwerkagentursaarland.de@localhost>]

On Fri, Feb 27, 2015 at 09:32:43AM +0100, Thomas Klausner wrote:
> On Thu, Feb 26, 2015 at 10:54:29PM +0100, Matthias Ferdinand wrote:
> > in archivers/zoo, in bsd.c, the time() function is called before the
> > respective #includes are read.
> 
> archivers/zoo builds fine for me from pkgsrc-current on NetBSD
> 7.99.5/amd64 as-is, without warnings even. What do you see and on what
> platform?
>  Thomas

Hi,

the problem shows on Linux systems: Ubuntu 12.04, Ubuntu 10.04, SuSE
10.0, SuSE 9.2.

-------- snip ------------

...
===> Building for zoo-2.10.1nb4
make CFLAGS="-c -O2 -DBSD4_3 -DANSI_HDRS" zoo fiz
gcc -c -O2 -DBSD4_3 -DANSI_HDRS  -DBIG_MEM -DNDEBUG addbfcrc.c
gcc -c -O2 -DBSD4_3 -DANSI_HDRS  -DBIG_MEM -DNDEBUG addfname.c
gcc -c -O2 -DBSD4_3 -DANSI_HDRS  -DBIG_MEM -DNDEBUG basename.c
gcc -c -O2 -DBSD4_3 -DANSI_HDRS  -DBIG_MEM -DNDEBUG comment.c
gcc -c -O2 -DBSD4_3 -DANSI_HDRS  -DBIG_MEM -DNDEBUG crcdefs.c
gcc -c -O2 -DBSD4_3 -DANSI_HDRS  -DBIG_MEM -DNDEBUG getfile.c
gcc -c -O2 -DBSD4_3 -DANSI_HDRS  -DBIG_MEM -DNDEBUG lzc.c
gcc -c -O2 -DBSD4_3 -DANSI_HDRS  -DBIG_MEM -DNDEBUG lzd.c
gcc -c -O2 -DBSD4_3 -DANSI_HDRS  -DBIG_MEM -DNDEBUG machine.c
In file included from machine.c:60:0:
bsd.c: In function 'gettz':
bsd.c:82:5: warning: assignment makes pointer from integer without a cast [enabled by default]
bsd.c:86:14: error: dereferencing pointer to incomplete type
In file included from nixtime.i:1:0,
                 from bsd.c:92,
                 from machine.c:60:
/usr/include/time.h: At top level:
/usr/include/time.h:186:15: error: conflicting types for 'time'
bsd.c:81:2: note: previous implicit declaration of 'time' was here
/usr/include/time.h:237:19: error: conflicting types for 'localtime'
bsd.c:82:7: note: previous implicit declaration of 'localtime' was here
*** Error code 1

Stop.
make: stopped in /opt/pkgsrc/work/pkgsrc/archivers/zoo/default
*** Error code 1

Stop.
bmake: stopped in /opt/pkgsrc/work/pkgsrc/archivers/zoo/default
*** Error code 1

Stop.
bmake: stopped in /opt/pkgsrc/usr/pkgsrc/archivers/zoo
*** Error code 1

Stop.
bmake: stopped in /opt/pkgsrc/usr/pkgsrc/archivers/zoo
-------- snip ------------


The nixtime.i is supposed to handle time on different systems, but is
only included after the first use of the time() function.


Regards
Matthias