Re: digest build is broken under cygwin

The build is complete by following your instructions but now it fails for the same reason on the install.

Following the relevant entry from config.log under work/digest:
INSTALL_DATA='/bin/install -c -o username -g Domain Users -m 644'
INSTALL_PROGRAM='/bin/install -c -s -o username -g Domain\ Users -m 755'

INSTALL_DATA brakes, i have searched around for entries similar to the once you proposed for the build hack but i wasnt successful by adding :Q, any suggestions are welcomed.

mk/configure/configure.mk

mk/configure/gnu-configure.mk
are the files that corrected the build.
diff configure.mk configure.mk.orig
195c195
< _CONFIGURE_SCRIPT_ENV+=       INSTALL=${INSTALL:Q}\ -c\ -o\ ${BINOWN:Q}\ -g\ ${BINGRP:Q}
---
> _CONFIGURE_SCRIPT_ENV+=       INSTALL=${INSTALL:Q}\ -c\ -o\ ${BINOWN}\ -g\ ${BINGRP}

diff gnu-configure.mk gnu-configure.mk.orig
18c18
< CONFIGURE_ENV+=       ac_given_INSTALL=${INSTALL:Q}\ -c\ -o\ ${BINOWN:Q}\ -g\ ${BINGRP:Q}
---
> CONFIGURE_ENV+=       ac_given_INSTALL=${INSTALL:Q}\ -c\ -o\ ${BINOWN}\ -g\ ${BINGRP}

Cheers

Andreas

On Thu, Feb 5, 2015 at 12:07 PM, Jonathan Perkin <jperkin%joyent.com@localhost> wrote:

* On 2015-02-04 at 18:36 GMT, Andreas Moschos wrote:

> latest cygwin on win 7.
>
> Build of digest is broken, building with:
> _PKGSRC_BARRIER=no bmake.exe -d A
>
> i can see the following:
>
> + cd /usr/pkgsrc/pkgtools/digest/work/digest-20121220
> + /bin/env 'INSTALL=/bin/install -c -o mysername -g Domain' Users
> 'INSTALL_PROGRAM=/bin/install .... (more output)
>
> and i get a message of "Users -- - unknown option"
>
> obviously the "Domain Users" is being interpreted wrong.

Right, there are probably quite a lot of places in pkgsrc
infrastructure where it is assumed users, groups, and paths will not
contain spaces. If you have time it'd be great if you could work
through them, adding the bmake :Q modifier anywhere it may be
necessary.

So, for your example, you'd change the line in
mk/configure/configure.mk from:

_CONFIGURE_SCRIPT_ENV+= INSTALL=${INSTALL:Q}\ -c\ -o\ ${BINOWN}\ -g\ ${BINGRP}

into:

_CONFIGURE_SCRIPT_ENV+= INSTALL=${INSTALL:Q}\ -c\ -o\ ${BINOWN:Q}\ -g\ ${BINGRP:Q}

and then try again with a clean rebuild.

Once you've fixed that one, move onto the next issue (there's another
one in mk/configure/gnu-configure.mk), and once it's working report
back and we can integrate the fix.

Thanks,

--
Jonathan Perkin - Joyent, Inc. - www.joyent.com