Re: [PATCH] lintpkgsrc cannot locate certain include files

["J. Lewis Muir" <jlmuir%imca-cat.org@localhost>]

On 1/10/15 2:14 PM, Thomas Klausner wrote:
> On Sat, Jan 10, 2015 at 08:28:08AM -0600, J. Lewis Muir wrote:
>> The verbose subroutine that gets called to display the output has a
>> "-t STDERR" guard around printing to the standard error stream, so it
>> won't print the message unless the standard error stream is opened
>> to a tty.  So, in your invocation, if you remove the redirection of
>> the standard error stream to a file, you should see the behavior
>> difference.
>
> Thanks, I could reproduce the problem and the improvement.

Hi, Thomas.

Great!  Thanks!

> You wouldn't perchance also have a fix for some of the remaining
> warnings I'm seeing?

Bummer.  I hadn't seen those because I hadn't run lintpkgsrc on a tree
with a wip checkout.

No, I don't have a fix for those.  I briefly looked into
"Bogus: PKGREVISION $(_SVN_PKGVERSION:S/.//g)", and I think the
lintpkgsrc parser doesn't know about the special ":sh" variable modifier
used in "${_SVN_PKGVERSION_CMD:sh}".  So, I think any PKGREVISION
variable being set via that automatic mechanism won't work.  I haven't
looked, but I would guess the same issue will exist for PKGREVISION
being automatically set for Git or CVS repos too.

I didn't look into "Bogus: ${PKGNAME:S/^suse_/suse32_/}".  That one is a
little surprising because I thought the lintpkgsrc parser *did* support
the ":S" variable modifier.

Obviously, lintpkgsrc could be modified to just skip all of those cases
it doesn't handle, but I don't know if that's an improvement since then
those cases will go silently unchecked.

It seems like the best thing would be to improve the lintpkgsrc parser.
It could be made to understand the various NetBSD makefile variable
modifiers.

Regards,

Lewis