Re: Cannot build Python 3.4 on Mac OS X (pkgsrc HEAD)

[Greg Troxel <gdt%ir.bbn.com@localhost>]

"J. Lewis Muir" <jlmuir%imca-cat.org@localhost> writes:

> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/lang/python34/Makefile,v
> retrieving revision 1.7
> diff -b -u -r1.7 Makefile
> --- Makefile	9 Oct 2014 09:15:38 -0000	1.7
> +++ Makefile	7 Jan 2015 23:14:04 -0000
> @@ -76,6 +76,12 @@
>  INSTALL_UNSTRIPPED=	yes
>  .endif
>  
> +# For Xcode 5 and up we need to search the SDK path for headers, otherwise
> +# certain modules will not be built.
> +.if ${OPSYS} == "Darwin" && exists(${OSX_SDK_PATH}/usr/include)
> +CFLAGS+=		-I${OSX_SDK_PATH}/usr/include
> +.endif
> +
>  PLIST_VARS+=	bsddb dll nis no-nis
>  .if ${OPSYS} == "IRIX"
>  .  if ${ABI} == "64"


I don't follow this for two reasons:

(nit) Shouldn't it be CPPFLAGS?

(real) This is not special about python34; it should apply to
everything, and our wrappers/etc. should be taking care of it.   How
this works is not immediately obvious.  But I suspect that rather than
adding CPPFLAGS, the right fix is to find out how this directory isn't
getting added when it should.