Re: pkg/49262: Firefox compile fails at AString.o

[Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>]

abs@ wrote:

> On 12 October 2014 10:35, Thomas Klausner <wiz%netbsd.org@localhost> wrote:
> > On Sun, Oct 12, 2014 at 10:05:48AM +0100, David Brownlee wrote:
> >> Anyone else seeing this? netbsd-6 tag amd64, fresh build of latest pkgsrc:
> >
> > Looks like 'pkg/49262: Firefox compile fails at AString.o'.
> 
> Aha - thanks. Looks like the system #define of tolower() under 6.x is
> interacting poorly with the "void tolower();" in struct AString {}.
> 
> ryoon@ just picked up the PR, so will leave in his very capable hands :)

Just FYI, the following kludge works around on NetBSD 6.1.5.
(though now firefox 33.0 is out)

--- media/libstagefright/frameworks/av/include/media/stagefright/foundation/AString.h.orig	2014-09-24 01:05:30.000000000 +0000
+++ media/libstagefright/frameworks/av/include/media/stagefright/foundation/AString.h
@@ -74,7 +74,10 @@
 
     bool startsWith(const char *prefix) const;
     bool endsWith(const char *suffix) const;
 
+#if defined(__NetBSD__) && defined(tolower)
+#undef tolower
+#endif
     void tolower();
 
 private:

---

Note ctype.h in NetBSD -current has #if !defined(__cplusplus) around
<sys/ctype_inline.h> which defines the macro so it happens to work.

---
Izumi Tsutsui