Potential bug fof giflib-5 support?

["OBATA Akio" <obata%lins.jp@localhost>]

Hi,

I found bugs introduced at giflib-5 support patch in graphics/imlib.

In pkgsrc/graphics/imlib/patches/patch-ak rev 1.2

-  gif = DGifOpenFileHandle(fd);
+  gif = DGifOpenFileHandle(fd, &giferror);

error is checked as whether "gif" is NULL or not below, so
second argument of DGifOpenFileHandle is redundant, just use NULL instead
(and no need to declare "int giferror" above).

       if (DGifGetRecordType(gif, &rec) == GIF_ERROR)
        {
-         PrintGifError();
+         PrintGifError(giferror);

this is wrong, giferror still hold an error for DGifOpenFileHandle(fd, 
&giferror),
and the error of DGifGetRecordType(gif, &rec) is stored in gif->Error.

Other package may have same wrong patches.
Please check if you have a time.

--
OBATA Akio / obata%lins.jp@localhost