Re: clang patch to build on solaris

[Joerg Sonnenberger <joerg%britannica.bec.de@localhost>]

On Tue, Dec 17, 2013 at 10:22:19PM +0100, Hans Rosenfeld wrote:
> On Tue, Dec 17, 2013 at 06:06:28PM +0100, Richard PALO wrote:
> > I believe this may need a bit wider testing on solaris, but with
> > this patched Makefile pkgsrc clang seems to build okay and work, at
> > least on the few programs I've tested.
> > 
> > I've built with pkgsrc gcc 4.8.2 and builtin gcc 4.7.3 on OpenIndiana.
> 
> Wow, great work!
> 
> > NB: solaris `ld' is found through paths, so it is probably neither a
> > good idea to use or build with */gnu/bin in your path.
> > 
> > This could probably be fixed by hardcoding the path to ld in place
> > of the call to 'getToolChain().GetProgramPath("ld")' in
> > clang/lib/Driver/Tools.cpp but I obstained from doing that for
> > now...
> 
> I would suggest doing exactly that, as you really need Solaris ld on
> anything SunOS. So GNU ld should never be picked up accidentally.

At least for upstream that is unacceptable. It would break
cross-compilation.

Joerg