Re: libtorrent/rtorrent patch for testing

[Matthias Scheler <tron%NetBSD.org@localhost>]

On Wed, Sep 11, 2013 at 02:46:47PM +0200, Joerg Sonnenberger wrote:
> On Mon, Sep 02, 2013 at 04:15:39PM +0200, Joerg Sonnenberger wrote:
> > Hi all,
> > attached patch is the second try to get libtorrent and rtorrent to
> > support both a traditional GCC STL implementation as well as libc++ in
> > C++11 mode. Please report any problems.
> 
> Ping.

Sorry, I missed the initial e-mail.

"rtorrent" doesn't build under Mac OS X Lion with 4.2.1 LVM:

++ -DHAVE_CONFIG_H -I. -I.. -I. -I..  -isystem /usr/include -I/usr/include 
-I/usr/pkg/include -I/usr/pkg/include/gettext  -pipe -O2 -I/usr/include 
-I/usr/pkg/include -I/usr/pkg/include/gettext -march=i486 -g -DDEBUG 
-D_THREAD_SAFE  -D_REENTRANT  -I/usr/pkg/include/sigc++-2.0 
-I/usr/pkg/lib/sigc++-2.0/include  -I/usr/pkg/include  -I/usr/pkg/include  -MT 
command_local.o -MD -MP -MF .deps/command_local.Tpo -c -o command_local.o 
command_local.cc
command_file.cc: In function 'void initialize_command_file()':
command_file.cc:119: error: cannot convert 'void (torrent::File::*)(int)' to 
'int' for argument '1' to 'int bind(int, const sockaddr*, socklen_t)'
command_file.cc:120: error: cannot convert 'void (torrent::File::*)(int)' to 
'int' for argument '1' to 'int bind(int, const sockaddr*, socklen_t)'
command_file.cc:121: error: cannot convert 'void (torrent::File::*)(int)' to 
'int' for argument '1' to 'int bind(int, const sockaddr*, socklen_t)'
command_file.cc:122: error: cannot convert 'void (torrent::File::*)(int)' to 
'int' for argument '1' to 'int bind(int, const sockaddr*, socklen_t)'
command_file.cc:124: error: cannot convert 'bool (torrent::File::*)(int)' to 
'int' for argument '1' to 'int bind(int, const sockaddr*, socklen_t)'
command_file.cc:125: error: cannot convert 'void (torrent::File::*)(int)' to 
'int' for argument '1' to 'int bind(int, const sockaddr*, socklen_t)'
command_file.cc:126: error: cannot convert 'void (torrent::File::*)(int)' to 
'int' for argument '1' to 'int bind(int, const sockaddr*, socklen_t)'
command_file.cc:127: error: cannot convert 'bool (torrent::File::*)(int)' to 
'int' for argument '1' to 'int bind(int, const sockaddr*, socklen_t)'
command_file.cc:128: error: cannot convert 'void (torrent::File::*)(int)' to 
'int' for argument '1' to 'int bind(int, const sockaddr*, socklen_t)'
command_file.cc:129: error: cannot convert 'void (torrent::File::*)(int)' to 
'int' for argument '1' to 'int bind(int, const sockaddr*, socklen_t)'
mv -f .deps/command_helpers.Tpo .deps/command_helpers.Po
g++ -DHAVE_CONFIG_H -I. -I.. -I. -I..  -isystem /usr/include -I/usr/include 
-I/usr/pkg/include -I/usr/pkg/include/gettext  -pipe -O2 -I/usr/include 
-I/usr/pkg/include -I/usr/pkg/include/gettext -march=i486 -g -DDEBUG 
-D_THREAD_SAFE  -D_REENTRANT  -I/usr/pkg/include/sigc++-2.0 
-I/usr/pkg/lib/sigc++-2.0/include  -I/usr/pkg/include  -I/usr/pkg/include  -MT 
command_network.o -MD -MP -MF .deps/command_network.Tpo -c -o command_network.o 
command_network.cc
command_dynamic.cc: In function 'void initialize_command_dynamic()':
command_dynamic.cc:444: error: no matching function for call to 
'bind(torrent::Object (*)(const std::vector<torrent::Object, 
std::allocator<torrent::Object> >&, int), std::tr1::_Placeholder<2>&, 
rpc::object_storage::<anonymous enum>)'
command_dynamic.cc:446: error: no matching function for call to 
'bind(torrent::Object (*)(const std::vector<torrent::Object, 
std::allocator<torrent::Object> >&, int), std::tr1::_Placeholder<2>&, 
rpc::object_storage::<anonymous enum>)'
command_events.cc: In function 'void initialize_command_events()':
command_events.cc:335: error: invalid conversion from 'torrent::Object 
(*)(const std::vector<torrent::Object, std::allocator<torrent::Object> >&, 
int)' to 'int'
command_events.cc:335: error: cannot convert 'std::tr1::_Placeholder<2>' to 
'const sockaddr*' for argument '2' to 'int bind(int, const sockaddr*, 
socklen_t)'
command_events.cc:340: error: invalid conversion from 'torrent::Object 
(*)(const std::vector<torrent::Object, std::allocator<torrent::Object> >&, 
int)' to 'int'
command_events.cc:340: error: cannot convert 'std::tr1::_Placeholder<2>' to 
'const sockaddr*' for argument '2' to 'int bind(int, const sockaddr*, 
socklen_t)'
command_dynamic.cc:457: error: no matching function for call to 'bind(bool 
(rpc::object_storage::*)(const std::string&, unsigned int), 
rpc::object_storage*, std::tr1::_Placeholder<2>&, 
rpc::object_storage::<anonymous enum>)'
command_dynamic.cc:459: error: no matching function for call to 'bind(void 
(rpc::object_storage::*)(const std::string&, unsigned int), 
rpc::object_storage*, std::tr1::_Placeholder<2>&, 
rpc::object_storage::<anonymous enum>)'
gnumake[3]: *** [command_file.o] Error 1
gnumake[3]: *** Waiting for unfinished jobs....
gnumake[3]: *** [command_events.o] Error 1
gnumake[3]: *** [command_dynamic.o] Error 1
mv -f .deps/command_ip.Tpo .deps/command_ip.Po
mv -f .deps/command_groups.Tpo .deps/command_groups.Po
command_download.cc: In function 'void initialize_command_download()':
command_download.cc:824: error: cannot convert 'void 
(torrent::DownloadInfo::*)(int)const' to 'int' for argument '1' to 'int 
bind(int, const sockaddr*, socklen_t)'
command_download.cc:825: error: cannot convert 'void 
(torrent::DownloadInfo::*)(int)const' to 'int' for argument '1' to 'int 
bind(int, const sockaddr*, socklen_t)'
mv -f .deps/command_local.Tpo .deps/command_local.Po
mv -f .deps/command_network.Tpo .deps/command_network.Po

Both packages build fine under NetBSD/amd64 6.1_STABLE with GCC 4.5.3.

        Kind regards

-- 
Matthias Scheler                                  http://zhadum.org.uk/