pkgsrc-Users archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/x11/xorg-cf-files

This patch is a result of some emails exchanged between David and me.
I think this discussion needs to be taken to the list again.

As far as I can tell, there are two problems with imake/tradcpp, which
have caused trouble in e.g. audio/nas and other packages:

- The Makefile generated by tradcpp does not work with bmake. I was
able build graphics/xv by adding

   USE_TOOLS+=          gmake

and print/transfig by using

   env IMAKEOPTS='-DMakeCmd=/usr/pkgsrc/20130422/bin/gmake' bmake

These are only short-term fixes, no real solutions!

- Installation of print/transfig fails, because tradcpp does only
define "__sun" but not "sun", so imake includes the wrong file
( instead of As a result, InstallCmd is "bsdinst"
(which is not present) instead of "install-sh".

My - totally personal - impression and opinion is:

- This change should be reverted. The mission of tradcpp is "to be
suitable for historical Unix uses of the pre-processor, such as
imake(1)". So tradcpp should be changed to suit imake, not the other
way around. If it is okay to tweak imake, there would be little reason
for tradcpp in the first place. Plus: "fixing" imake in pkgsrc only
does not help other uses of tradcpp outside pkgsrc.

- The use of tradcpp should be restricted to situations where no other
suitable cpp is available (to my understanding, this is the case when
using e.g. clang instead of GCC). I think it is not a good plan to
first break stuff by using a different preprocessor when a capable is
installed, and then to work around all the generated fall-out with
more hacks.

- If tradcpp is used unconditionally, gmake should be automatically
used in all affected packages instead of bmake, on those platforms
that use bmake.

On Wed, Jul 17, 2013 at 8:13 AM, David A. Holland 
<> wrote:
> Module Name:    pkgsrc
> Committed By:   dholland
> Date:           Wed Jul 17 06:13:22 UTC 2013
> Modified Files:
>         pkgsrc/x11/xorg-cf-files: Makefile distinfo
>         pkgsrc/x11/xorg-cf-files/patches: patch-ag
> Log Message:
> Recognize "__sun" as well as "sun" as tradcpp doesn't define the
> latter. Otherwise, Solaris ends up using the svr4 config and assorted
> crazy things happen. Diagnosed by Joern Clausen. PKGREVISION -> 6.
> To generate a diff of this commit:
> cvs rdiff -u -r1.23 -r1.24 pkgsrc/x11/xorg-cf-files/Makefile
> cvs rdiff -u -r1.17 -r1.18 pkgsrc/x11/xorg-cf-files/distinfo
> cvs rdiff -u -r1.3 -r1.4 pkgsrc/x11/xorg-cf-files/patches/patch-ag
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

Joern Clausen

Home | Main Index | Thread Index | Old Index