Re: Please review my update of scrotwm - some issues during make phase

[Tomas Bodzar <tomas.bodzar%gmail.com@localhost>]

On Tue, Oct 18, 2011 at 11:21 PM, Matthias Rampke
<matthias.rampke%googlemail.com@localhost> wrote:
> next thing:
>
> .include "../../x11/xextproto/buildlink3.mk"
>
> it was missing a header from x11/xextproto on DragonFly master, with this it 
> builds and installs, didn;t test if it works yet.

It's not case here in NetBSD. At least it seems so for me. The weird
issue is that it's not creating .o files or it is, but in wrong
directory. See below.


$ bmake
=> Bootstrap dependency curl-[0-9]*: found curl-7.21.7
=> Bootstrap dependency digest>=20010302: found digest-20080510
=> Checksum SHA1 OK for scrotwm-0.9.34.tgz
=> Checksum RMD160 OK for scrotwm-0.9.34.tgz
===> Installing dependencies for scrotwm-0.9.34
=> Build dependency gmake>=3.81: found gmake-3.82nb2
=> Build dependency x11-links>=0.66: found x11-links-0.68
=> Build dependency checkperms>=1.1: found checkperms-1.11
=> Full dependency dmenu-[0-9]*: found dmenu-4.1.1
===> Overriding tools for scrotwm-0.9.34
===> Extracting for scrotwm-0.9.34
===> Patching for scrotwm-0.9.34
=> Applying pkgsrc patches for scrotwm-0.9.34
===> Creating toolchain wrappers for scrotwm-0.9.34
===> Configuring for scrotwm-0.9.34
=> Checking for portability problems in extracted files
===> Building for scrotwm-0.9.34
ln -sf ../scrotwm.c
gcc -pipe -I/usr/X11R7/include -I/usr/pkg/include -Wall -ggdb
-D_GNU_SOURCE -I. -DSWM_LIB=\"/usr/pkg/lib/libswmhack.so.0.0\"
-I/usr/pkg/include -I/usr/X11R7/include  -c -o linux.o linux.c
ln -sf ../lib/swm_hack.c
gcc -pipe -I/usr/X11R7/include -I/usr/pkg/include -Wall -ggdb
-D_GNU_SOURCE -I. -DSWM_LIB=\"/usr/pkg/lib/libswmhack.so.0.0\"
-I/usr/pkg/include -I/usr/X11R7/include  -c -o scrotwm.o scrotwm.c
gcc -pipe -I/usr/X11R7/include -I/usr/pkg/include -Wall -ggdb
-D_GNU_SOURCE -I. -DSWM_LIB=\"/usr/pkg/lib/libswmhack.so.0.0\" -c
-fpic -DPIC swm_hack.c -o swm_hack.so
scrotwm.c: In function 'send_to_ws':
scrotwm.c:3061:6: warning: pointer targets in passing argument 1 of
'snprintf' differ in signedness
/usr/include/stdio.h:346:6: note: expected 'char * __restrict__' but
argument is of type 'unsigned char *'
scrotwm.c: In function 'uniconify':
scrotwm.c:3175:8: warning: pointer targets in assignment differ in signedness
scrotwm.c: In function 'search_do_resp':
scrotwm.c:3218:8: warning: pointer targets in assignment differ in signedness
scrotwm.c: In function 'window_get_pid':
scrotwm.c:4991:2: warning: pointer targets in passing argument 1 of
'strtonum' differ in signedness
./util.h:15:11: note: expected 'const char *' but argument is of type
'unsigned char *'
scrotwm.c: In function 'manage_window':
scrotwm.c:5085:3: warning: pointer targets in passing argument 1 of
'strtonum' differ in signedness
./util.h:15:11: note: expected 'const char *' but argument is of type
'unsigned char *'
scrotwm.c:5126:6: warning: pointer targets in passing argument 1 of
'snprintf' differ in signedness
/usr/include/stdio.h:346:6: note: expected 'char * __restrict__' but
argument is of type 'unsigned char *'
swm_hack.c: In function 'set_property':
swm_hack.c:111:8: warning: pointer targets in passing argument 7 of
'xcp' differ in signedness
swm_hack.c:111:8: note: expected 'unsigned char *' but argument is of
type 'char *'
gcc -shared -fpic -o libswmhack.so.0.0 swm_hack.so -lX11 -lXrandr -lXtst
gcc -L/usr/X11R7/lib -Wl,-R/usr/X11R7/lib -L/usr/pkg/lib
-Wl,-R/usr/pkg/lib -o scrotwm scrotwm.o linux.o -lX11 -lXrandr -lXtst
=> Unwrapping files-to-be-installed.
$

$ find work/scrotwm-0.9.34/ -iname *.o
work/scrotwm-0.9.34/linux/scrotwm.o
work/scrotwm-0.9.34/linux/linux.o
$

$ pwd
/usr/pkgsrc/wip/scrotwm
$


>
> --matthiasr
>