Re: multimedia/vlc does not configure (x11-xcb) (blocking bug)

[Rhialto <rhialto%falu.nl@localhost>]

On Sun 08 May 2011 at 09:55:55 +0700, Robert Elz wrote:
> That works, at least to get the build past the configure stage
> (it is still compiling as I send this).

I kept this mail while compiling, so this bit applies after "make
package". I had read your mail about the extra file
plugins-04041e-1e8.dat, and in anticipation of that, added it to my
PLIST. Strangely enough, I didn't get it, so "make package" failed for
that opposite reason at first.

I tried running vlc without actually installing it, which was a bit
tricky, but with an explicit LD_LIBRARY_PATH for the libraries inside
the chroot and an --plugin-path to point to the vlc plugins, it ran.
No image, however, with default settings. I changed Video -> Output
Modules to "X11 video output (XCB)" and I got image. Full-screen however
didn't seem to work, and resizing the window froze the image for a
while. "XVideo output (XCB)" gave just a black output. I think that this
is the one you normally want.

> ps: the configure, and whatever leads up to it (and the compile, or
> what I have seen of it) is very noisy - ie: lots of warnings about all
> kinds of crud (lots of libtool warnings, and stuff like that) - more
> than I am used to seeing in pkgsrc packages.

The configure seems to check for some more things that we don't provide
to it; I happened to see SQLite. I don't know what it would use it for
but there might be some extra options needed to add such things.

My comments on the patch:

> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/NetBSD/pkgsrc/multimedia/vlc/Makefile,v
> retrieving revision 1.111
> diff -u -r1.111 Makefile
> --- Makefile  22 Apr 2011 13:42:03 -0000      1.111
> +++ Makefile  8 May 2011 02:21:27 -0000
> @@ -26,7 +26,7 @@
>  CONFIGURE_ARGS+=     --with-kde-solid=${PREFIX}/share/kde/apps/solid/actions
>  PTHREAD_OPTS+=               require
>  USE_LANGUAGES=               c99 c++
> -PLIST_VARS+=         x86simd altivec v4l2 vcd cdda
> +PLIST_VARS+=         x86simd altivec v4l2 vcd cdda glx
>  
>  .include "../../mk/bsd.prefs.mk"
>  .include "options.mk"
> @@ -152,6 +152,11 @@
>  # libX11 should be built with xcb enabled
>  BUILDLINK_API_DEPENDS.libX11+=       libX11>=1.3.5
>  .include "../../x11/libX11/buildlink3.mk"
> +.if ${X11_TYPE} == "modular" || exists(${X11BASE}/lib/pkgconfig/xcb.pc)

Perhaps it should check for ${X11BASE}/lib/pkgconfig/x11-xcb.pc
because I do have a /usr/pkg/lib/pkgconfig/xcb.pc (but not a
/usr/X11R7/lib/pkgconfig/xcb.pc). x11-xcb.pc is what vlc's configure
checks for with PKG_CHECK_MODULES(XLIB_XCB, [x11-xcb]).

> +PLIST.glx=   yes
> +.else
> +CONFIGURE_ARGS+=     --disable-glx

There is an "--enable-glx" in options.mk, conditional on option "x11".
I suppose that "--enable-glx" should be removed there, and the "x11"
condition should be added here.

> +.endif
>  # needs x264_encoder_delayed_frames
>  BUILDLINK_API_DEPENDS.x264-devel+= x264-devel>=20100201
>  .include "../../multimedia/x264-devel/buildlink3.mk"
> Index: PLIST
> ===================================================================
> RCS file: /cvsroot/NetBSD/pkgsrc/multimedia/vlc/PLIST,v
> retrieving revision 1.41
> diff -u -r1.41 PLIST
> --- PLIST     6 Apr 2011 08:14:21 -0000       1.41
> +++ PLIST     8 May 2011 02:22:53 -0000
> @@ -339,7 +339,7 @@
>  ${PLIST.x11}lib/vlc/plugins/video_output/libsnapshot_plugin.la
>  lib/vlc/plugins/video_output/libvmem_plugin.la
>  lib/vlc/plugins/video_output/libvout_wrapper_plugin.la
> -${PLIST.x11}lib/vlc/plugins/video_output/libxcb_glx_plugin.la
> +${PLIST.glx}lib/vlc/plugins/video_output/libxcb_glx_plugin.la
>  ${PLIST.x11}lib/vlc/plugins/video_output/libxcb_window_plugin.la
>  ${PLIST.x11}lib/vlc/plugins/video_output/libxcb_x11_plugin.la
>  ${PLIST.x11}lib/vlc/plugins/video_output/libxcb_xv_plugin.la

Thanks,
-Olaf.
-- 
___ Olaf 'Rhialto' Seibert  -- There's no point being grown-up if you 
\X/ rhialto/at/xs4all.nl    -- can't be childish sometimes. -The 4th Doctor