Re: xine-ui versus XF86VidModeSwitchToMode

[Rhialto <rhialto%falu.nl@localhost>]

On Thu 04 Nov 2010 at 10:04:02 +0100, Bernd Ernesti wrote:
> On Thu, Nov 04, 2010 at 08:59:28AM +0100, Bernd Ernesti wrote:
> > On Wed, Nov 03, 2010 at 11:48:49PM +0000, Matthias Scheler wrote:
> > > On Wed, Nov 03, 2010 at 10:31:50PM +0100, Bernd Ernesti wrote:
> > > > pkgsrc/pkgtools/x11-links/xorg.mk/xorg.mk
> > > > 
> > > > revision 1.21
> > > > date: 2010/09/14 19:40:15;  author: tron;  state: Exp;  lines: +3 -5
> > > > Update "x11-links" package to version 0.60:
> > > > There is no fallback to use the version from pkgsrc and in the
> > > > xf86vidmodeproto ...
> > > 
> > > Well, that seems to be the real bug. "xine-ui/Makefile" probably needs
> > > this line to fix the build:
> > > 
> > > .include "../../x11/xf86vidmodeproto/buildlink3.mk"
> > 
> > IMHO that is already included by the x11/libXxf86vm/buildlink3 one
> > and seeems not to work.
> 
> Because it will not be inculded due to a check for X11_TYPE != "modular"
> 
> I guess that this and a few other buildlink3.mk files are broken.
> Does that mean that these packages also need a builtin.mk file?

Well, if application A uses library L, A should not need to know that L
needs M. So perhaps the inclusion should not depend on X11_TYPE.

By the way, it looks like these buildlink.mk files are duplicating
information that is in the pkg-config (.pc) files (viz, that library L
needs another library/header/whatever M). That is never a good thing.
Perhaps they should be auto-generated or something.

> Bernd
-Olaf.
-- 
___ Olaf 'Rhialto' Seibert  -- There's no point being grown-up if you 
\X/ rhialto/at/xs4all.nl    -- can't be childish sometimes. -The 4th Doctor
X5O!P%@AP[4\PZX54(P^)7CC)7}$EICAR-STANDARD-ANTIVIRUS-TEST-FILE!$H+H*