Re: comms/libopensync

["OBATA Akio" <obache%netbsd.org@localhost>]

On Tue, 09 Jun 2009 12:15:48 +0900, Brook Milligan 
<brook%biology.nmsu.edu@localhost> wrote:

> First, I just tried to build it and ran into a problem with the
> following pre-fetch target.
>
>      DISTURL=${MASTER_SITES}${DISTNAME}${EXTRACT_SUFX}?format=raw
>      pre-fetch:
>            ${TEST} -f ${DISTDIR}/${DISTNAME}${EXTRACT_SUFX} || \
>            (cd ${DISTDIR} && ${FETCH_CMD} -o ${DISTNAME}${EXTRACT_SUFX} 
> ${DISTURL:Q})
>
> The most immediate problem is that the new ${FETCH_USING} constructs
> break this because ${FETCH_CMD} is not defined.  However, it appearrs
> that this (i.e., the '?format=raw' part) is completely unnecessary, as
> eliminating this entire section fetches a file with the expected
> checksum.  Thus, I propose removing it.

pre-fetch target should be removed after MASTER_SITE moved from the wiki to 
the normal site.

I've commited the fix.

> This raises a more general question.  The maintainer of this package
> is 'pkgsrc-users'.  In situations like this, i.e., given no real
> maintainer, is it appropriate to just make these kinds of changes
> directly?  To what degree should they be discussed here first?

It depends on the situation, whether the change have a large impact or not.

IMO, for this case, no need to ask to pkgsrc-users if you know why
the target exists and no need anymore, and put the reason in commit logs.

-- 
"Of course I love NetBSD":-)
OBATA Akio / obache%NetBSD.org@localhost