Re: pkg/34723 (pkgsrc patch crashes links and links-gui)

[Christian Biere <christianbiere%gmx.de@localhost>]

Christian Biere wrote:
> wiz%netbsd.org@localhost wrote:
> > Synopsis: pkgsrc patch crashes links and links-gui
> > 
> > Responsible-Changed-From-To: pkg-manager->is
> > Responsible-Changed-By: wiz%netbsd.org@localhost
> > Responsible-Changed-When: Fri, 06 Oct 2006 07:19:07 +0000
> > Responsible-Changed-Why:
> > is added the patch.
 
> Index: distinfo
> ===================================================================
> RCS file: /cvsroot/pkgsrc/www/links/distinfo,v
> retrieving revision 1.47
> diff -u -p -r1.47 distinfo
> --- distinfo  21 May 2008 14:00:40 -0000      1.47
> +++ distinfo  20 Jun 2008 21:27:43 -0000
> @@ -1,7 +1,6 @@
> -$NetBSD: distinfo,v 1.47 2008/05/21 14:00:40 wiz Exp $
> +$NetBSD$
>  
>  SHA1 (links-2.1pre36.tar.bz2) = 79ff4ff2d663de99ba590e11f42a52435a6e1809
>  RMD160 (links-2.1pre36.tar.bz2) = e34d61aa6db196d897afd4f07c1eb6f3a87dd4eb
>  Size (links-2.1pre36.tar.bz2) = 3824394 bytes
> -SHA1 (patch-aa) = 374bd3262b4f50712cd42898d67e90ebcba72577
>  SHA1 (patch-ab) = a2d461c9d8b6300469ab6195886830fdd63be837

I find it unbelievable that after almost TWO YEARS, this patch which
does nothing but adding bugs, is still in pkgsrc.

The patch can be seen here:
http://ftp.netbsd.org/pub/NetBSD/packages/pkgsrc/www/links/patches/patch-aa

Even without looking at the context of it, the patch is really poor C and has
multiple bugs in itself.

-- 
Christian