lang/guile Makefile strangeness on MacOS X

["John D. Baker" <jdbaker%mylinuxisp.com@localhost>]

Since pkgsrc-2007Q3, whenever I perform an operation that involves
lang/guile/Makefile ('lintpkgsrc -r -u', 'bmake clean-depends' on
some packages, etc.), I get the following messages:

[...]
===> Cleaning for libxml2-2.6.31
===> Cleaning for shared-mime-info-0.23
===> Cleaning for libtool-base-1.5.24nb5
bmake: "/Volumes/NetBSD/pkgsrc/lang/guile/Makefile" line 65: warning: duplicate script 
for target "post-patch" ignored
bmake: "/Volumes/NetBSD/pkgsrc/lang/guile/Makefile" line 48: warning: using previous 
script for "post-patch" defined here
===> Cleaning for freetype2-2.3.5
===> Cleaning for jpeg-6bnb4
===> Cleaning for png-1.2.25
===> Cleaning for gd-2.0.35
===> Cleaning for autoconf-2.61
===> Cleaning for gmp-4.2.2
===> Cleaning for libltdl-1.5.24
===> Cleaning for readline-5.2nb1
bmake: "/usr/pkgsrc/lang/guile/Makefile" line 65: warning: duplicate script for target 
"post-patch" ignored
bmake: "/usr/pkgsrc/lang/guile/Makefile" line 48: warning: using previous script for 
"post-patch" defined here
===> Cleaning for guile-1.8.4nb2
===> Cleaning for libgeda-1.4.0
===> Cleaning for gettext-lib-0.14.6
[...]

I see that there is a special-case "post-patch:" target for Darwin, but
the above messages would indicate that it will be ignored.

Perhaps it should be restructure like:

.if ${OPSYS} != "Darwin"
post-patch:
        ${TOUCH} ${WRKSRC}/libguile/scmconfig.h
        ${ECHO} "(define-module (ice-9 slib))" > ${WRKSRC}/ice-9/slib.scm
        ${ECHO} "(load-from-path \"slib/guile.init\")" >> 
${WRKSRC}/ice-9/slib.scm
.endif

.if ${OPSYS} == "Darwin"
CPPFLAGS+=              -Dmacosx

post-patch:
        ${TOUCH} ${WRKSRC}/libguile/scmconfig.h
        ${ECHO} "(define-module (ice-9 slib))" > ${WRKSRC}/ice-9/slib.scm
        ${ECHO} "(load-from-path \"slib/guile.init\")" >> 
${WRKSRC}/ice-9/slib.scm
        ${MV} ${WRKSRC}/guile-config/guile-config.in.orig \
            ${WRKSRC}/guile-config/guile-config.in
.endif


(Unless the general case doesn't apply to Darwin at all, then don't dup
script for the non-Darwin case.)


Thoughts?

--
John D. Baker, KN5UKS                    NetBSD     Darwin/MacOS X
jdbaker(at)mylinuxisp(dot)com                 OpenBSD            FreeBSD
BSD -- It just sits there and _works_!
GPG fingerprint:  D703 4A7E 479F 63F8 D3F4  BD99 9572 8F23 E4AD 1645