errno changes in signal.h (was: CVS commit: src/include)

[Bernd Ernesti <netbsd%lists.veego.de@localhost>]

On Sun, Feb 24, 2008 at 11:01:19PM +0000, David A. Holland wrote:
> 
> Module Name:  src
> Committed By: dholland
> Date:         Sun Feb 24 23:01:19 UTC 2008
> 
> Modified Files:
>       src/include: errno.h signal.h
> 
> Log Message:
> signal.h is not supposed to define errno, so use ___errno instead.
> Adjust errno.h in a compatible fashion to avoid -Wredundant-decls issues.
> I have run a build to check the tree for places where errno.h is missing,
> and fixed the cases I found, but there might be more in MD code.

Not only in MD code, but also in pkgsrc.

e.g. pkgsrc/audio/rplay

in rplayd/connection.c and rplayd/rplayd.c

Where I don't understand why pkgsrc doesn't stop the build after the first
error appears:

connection.c: In function 'connection_server_open':
connection.c:206: error: 'errno' undeclared (first use in this function)
connection.c:206: error: (Each undeclared identifier is reported only once
connection.c:206: error: for each function it appears in.)
connection.c: In function 'connection_client_open':
connection.c:310: error: 'errno' undeclared (first use in this function)
connection.c: In function 'connection_update':
connection.c:407: error: 'errno' undeclared (first use in this function)
connection.c: In function 'event_update':
connection.c:1782: error: 'errno' undeclared (first use in this function)
*** Error code 1

Stop.
make: stopped in /pkgsrc/audio/rplay/work.i386/rplay-3.3.2/rplayd
make all in rplay...
cc -c -I/usr/pkg/include -I/usr/include -I. -I../include -I./../include 
-I./../lib -DHAVE_CONFIG_H -O2 -I/usr/pkg/include -I/usr/include rplay.c
[..]

This was a pkg_check -a task to build missing packages.
Even the make install target was run, resulting in an incomplette package due
to the missing rplayd.

Bernd