Subject: 2006Q1 multimedia/vlc fails to build on 3.0/amd64
To: None <pkgsrc-users@NetBSD.org>
From: Rhialto <rhialto@falu.nl>
List: pkgsrc-users
Date: 04/04/2006 20:10:33
Still the same issue that I reported earlier. Gcc *really* needs these
casts! I don't understand why my patch hasn't been incorporated.

The first one:
===> build-message [vlc-0.7.2nb9] ===> Building for vlc-0.7.2nb9
...
if c++ -DHAVE_CONFIG_H -I. -I. -I../../..   -I/usr/pkg/include -I/usr/include -DGLX_GLXEXT_LEGACY -I/usr/pkg/include/freetype2 -I/usr/X11R6/include -DSYS_NETBSD -I../../../include `top_builddir="../../.." ../../../vlc-config --cxxflags plugin wxwindows` -Wsign-compare -Wsign-compare -Wall -O2 -I/usr/pkg/include -I/usr/include -DGLX_GLXEXT_LEGACY -I/usr/pkg/include/freetype2 -I/usr/X11R6/include -pthread -finline-limit-30000 -pipe -MT libwxwindows_plugin_a-open.o -MD -MP -MF ".deps/libwxwindows_plugin_a-open.Tpo" \
  -c -o libwxwindows_plugin_a-open.o `test -f 'open.cpp' || echo './'`open.cpp; \
then mv -f ".deps/libwxwindows_plugin_a-open.Tpo" ".deps/libwxwindows_plugin_a-open.Po"; \
else rm -f ".deps/libwxwindows_plugin_a-open.Tpo"; exit 1; \
fi
In file included from ../../../include/vlc_common.h:888,
                 from ../../../include/vlc/vlc.h:135,
                 from open.cpp:32:
../../../include/vlc_threads_funcs.h: In function `int __vlc_mutex_lock(char*, 
   int, vlc_mutex_t*)':
../../../include/vlc_threads_funcs.h:114: warning: cast from pointer to integer 
   of different size
../../../include/vlc_threads_funcs.h: In function `int 
   __vlc_mutex_unlock(char*, int, vlc_mutex_t*)':
../../../include/vlc_threads_funcs.h:187: warning: cast from pointer to integer 
   of different size
../../../include/vlc_threads_funcs.h: In function `int __vlc_cond_signal(char*, 
   int, vlc_cond_t*)':
../../../include/vlc_threads_funcs.h:325: warning: cast from pointer to integer 
   of different size
../../../include/vlc_threads_funcs.h: In function `int 
   __vlc_cond_broadcast(char*, int, vlc_cond_t*)':
../../../include/vlc_threads_funcs.h:472: warning: cast from pointer to integer 
   of different size
../../../include/vlc_threads_funcs.h: In function `int __vlc_cond_wait(char*, 
   int, vlc_cond_t*, vlc_mutex_t*)':
../../../include/vlc_threads_funcs.h:662: warning: cast from pointer to integer 
   of different size
open.cpp: In constructor `wxvlc::OpenDialog::OpenDialog(intf_thread_t*, 
   wxWindow*, int, int, int)':
open.cpp:385: error: call of overloaded `wxComboBox(wxPanel*&, <anonymous 
   enum>, const char[1], wxPoint, wxSize, int, NULL)' is ambiguous
/pkg_comp/obj/pkgsrc/multimedia/vlc/default/.buildlink/include/wx-2.6/wx/gtk/combobox.h:65: error: candidates
   are: wxComboBox::wxComboBox(wxWindow*, int, const wxString&, const wxPoint&, 
   const wxSize&, const wxArrayString&, long int, const wxValidator&, const 
   wxString&)
/pkg_comp/obj/pkgsrc/multimedia/vlc/default/.buildlink/include/wx-2.6/wx/gtk/combobox.h:54: error: 
                  wxComboBox::wxComboBox(wxWindow*, int, const wxString&, const 
   wxPoint&, const wxSize&, int, const wxString*, long int, const wxValidator&, 
   const wxString&)
open.cpp:442: warning: `__comp_ctor' is deprecated (declared at 
   /pkg_comp/obj/pkgsrc/multimedia/vlc/default/.buildlink/include/wx-2.6/wx/sizer.h
   :788)
open.cpp: In member function `wxPanel* wxvlc::OpenDialog::FilePanel(wxWindow*)
   ':
open.cpp:566: error: call of overloaded `wxComboBox(wxPanel*&, <anonymous 
   enum>, const char[1], wxPoint, wxSize, int, NULL)' is ambiguous
/pkg_comp/obj/pkgsrc/multimedia/vlc/default/.buildlink/include/wx-2.6/wx/gtk/combobox.h:65: error: candidates
   are: wxComboBox::wxComboBox(wxWindow*, int, const wxString&, const wxPoint&, 
   const wxSize&, const wxArrayString&, long int, const wxValidator&, const 
   wxString&)
/pkg_comp/obj/pkgsrc/multimedia/vlc/default/.buildlink/include/wx-2.6/wx/gtk/combobox.h:54: error: 
                  wxComboBox::wxComboBox(wxWindow*, int, const wxString&, const 
   wxPoint&, const wxSize&, int, const wxString*, long int, const wxValidator&, 
   const wxString&)
gmake[6]: *** [libwxwindows_plugin_a-open.o] Error 1
gmake[6]: Leaving directory `/pkg_comp/obj/pkgsrc/multimedia/vlc/default/vlc-0.7.2/modules/gui/wxwindows'
gmake[5]: *** [all-modules] Error 1
gmake[5]: Leaving directory `/pkg_comp/obj/pkgsrc/multimedia/vlc/default/vlc-0.7.2/modules/gui/wxwindows'
gmake[4]: *** [all-recursive] Error 1
gmake[4]: Leaving directory `/pkg_comp/obj/pkgsrc/multimedia/vlc/default/vlc-0.7.2/modules/gui'
gmake[3]: *** [all] Error 2
gmake[3]: Leaving directory `/pkg_comp/obj/pkgsrc/multimedia/vlc/default/vlc-0.7.2/modules/gui'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/pkg_comp/obj/pkgsrc/multimedia/vlc/default/vlc-0.7.2/modules'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `/pkg_comp/obj/pkgsrc/multimedia/vlc/default/vlc-0.7.2'
gmake: *** [all] Error 2
*** Error code 2

Stop.
make: stopped in /usr/pkgsrc/multimedia/vlc
===> /pkg_comp/obj/pkgsrc/multimedia/vlc/default/.build_done [vlc-0.7.2nb9] ===> 
===> /pkg_comp/obj/pkgsrc/multimedia/vlc/default/.build_done [vlc-0.7.2nb9] ===> There was an error during the ``build'' phase.
===> /pkg_comp/obj/pkgsrc/multimedia/vlc/default/.build_done [vlc-0.7.2nb9] ===> Please investigate the following for more information:
===> /pkg_comp/obj/pkgsrc/multimedia/vlc/default/.build_done [vlc-0.7.2nb9] ===>      * log of the build
===> /pkg_comp/obj/pkgsrc/multimedia/vlc/default/.build_done [vlc-0.7.2nb9] ===>      * /pkg_comp/obj/pkgsrc/multimedia/vlc/default/.work.log
===> /pkg_comp/obj/pkgsrc/multimedia/vlc/default/.build_done [vlc-0.7.2nb9] ===> 
*** Error code 1

Stop.
make: stopped in /usr/pkgsrc/multimedia/vlc

Patches:


$NetBSD$

--- modules/gui/wxwindows/open.cpp.dist	2005-10-04 20:53:11.000000000 +0000
+++ modules/gui/wxwindows/open.cpp	2005-10-04 20:52:50.000000000 +0000
@@ -382,7 +382,7 @@
                                                 wxU(_("Open:")) );
     mrl_combo = new wxComboBox( panel, MRL_Event, wxT(""),
                                 wxPoint(20,25), wxSize(120, -1),
-                                0, NULL );
+                                0, (const wxString*)NULL );
     mrl_combo->SetToolTip( wxU(_("You can use this field directly by typing "
         "the full MRL you want to open.\n""Alternatively, the field will be "
         "filled automatically when you use the controls below.")) );
@@ -563,7 +563,7 @@
     wxBoxSizer *file_sizer = new wxBoxSizer( wxHORIZONTAL );
 
     file_combo = new wxComboBox( panel, FileName_Event, wxT(""),
-                                 wxPoint(20,25), wxSize(200, -1), 0, NULL );
+                                 wxPoint(20,25), wxSize(200, -1), 0, (const wxString*)NULL );
     wxButton *browse_button = new wxButton( panel, FileBrowse_Event,
                                             wxU(_("Browse...")) );
     file_sizer->Add( file_combo, 1, wxALL, 5 );


$NetBSD$

--- modules/gui/wxwindows/streamout.cpp.dist	2004-05-16 11:42:29.000000000 +0000
+++ modules/gui/wxwindows/streamout.cpp	2005-10-04 21:12:15.000000000 +0000
@@ -166,7 +166,7 @@
     wxStaticText *mrl_label = new wxStaticText( panel, -1,
                                                 wxU(_("Destination Target:")));
     mrl_combo = new wxComboBox( panel, MRL_Event, wxT(""),
-                                wxPoint(20,25), wxSize(120, -1), 0, NULL );
+                                wxPoint(20,25), wxSize(120, -1), 0, (const wxString*)NULL );
     mrl_combo->SetToolTip( wxU(_("You can use this field directly by typing "
         "the full MRL you want to open.\n""Alternatively, the field will be "
         "filled automatically when you use the controls below")) );
@@ -447,7 +447,7 @@
     subpanel_sizer = new wxFlexGridSizer( 3, 2, 20 );
     label = new wxStaticText( access_subpanels[1], -1, wxU(_("Filename")) );
     file_combo = new wxComboBox( access_subpanels[1], FileName_Event, wxT(""),
-                                 wxPoint(20,25), wxSize(200, -1), 0, NULL );
+                                 wxPoint(20,25), wxSize(200, -1), 0, (const wxString*)NULL );
     wxButton *browse_button = new wxButton( access_subpanels[1],
                                   FileBrowse_Event, wxU(_("Browse...")) );
     subpanel_sizer->Add( label, 0, wxALIGN_RIGHT | wxALIGN_CENTER_VERTICAL );

$NetBSD$

--- modules/gui/wxwindows/subtitles.cpp.dist	2005-10-04 21:27:59.000000000 +0000
+++ modules/gui/wxwindows/subtitles.cpp	2005-10-04 21:15:09.000000000 +0000
@@ -85,7 +85,7 @@
     char *psz_subsfile = config_GetPsz( p_intf, "sub-file" );
     if( !psz_subsfile ) psz_subsfile = strdup("");
     file_combo = new wxComboBox( panel, -1, wxL2U(psz_subsfile),
-                                 wxPoint(20,25), wxSize(300, -1), 0, NULL );
+                                 wxPoint(20,25), wxSize(300, -1), 0, (const wxString *)NULL );
     if( psz_subsfile ) free( psz_subsfile );
     wxButton *browse_button = new wxButton( panel, FileBrowse_Event,
                                             wxU(_("Browse...")) );

-Olaf.
-- 
___ Olaf 'Rhialto' Seibert      -- You author it, and I'll reader it.
\X/ rhialto/at/xs4all.nl        -- Cetero censeo "authored" delendum esse.