pkgsrc-Changes archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: CVS commit: pkgsrc/devel/nss
Hi!
Good catch.
I've just added the list to the export definitions file for libssl3.
Before:
# nm -D ./nss/lib/ssl/NetBSD11.99.11_64_OPT.OBJ/libssl3.so | grep MLDSA
#
After:
# nm -D ./nss/lib/ssl/NetBSD11.99.11_64_OPT.OBJ/libssl3.so | grep MLDSA
000000000005a3ae T _ZN7mozilla4pkix24VerifyMLDSASignedDataNSSENS0_5InputENS0_17MLDSAParameterSetES1_S1_Pv@@NSS_3.134
#
I haven't tried firefox (with the patch) again, yet.
Thomas
On Fri, Nov 20, 2026 at 12:24:57PM +0100, Ryo ONODERA wrote:
> Hi,
>
> Thanks for your efforts.
>
> I have locally modified nss which use gyp to build.
> Each libnss3.so have different symbols.
> libnss3.so built by gmake has some C++ symbols including mozilla::pkix::VerifyMLDSASignedDataNSS.
> However libnss3.so built by gyp has no such symbols.
>
> libnss3.so built by gmake has a visibility problem for mozilla::pkix::VerifyMLDSASignedDataNSS and so on.
> I think that this visibility issue causes the build failure of www/firefox.
>
> I do not find any clue yet.
>
> Thank you.
>
> On November 20, 2026 7:02:01 AM GMT+09:00, Thomas Klausner <wiz%netbsd.org@localhost> wrote:
> >Hi!
> >
> >I've found that we probably also need to apply
> >https://github.com/mozilla-firefox/firefox/commit/6fa1b15d2bfca8e1bef7516890dec7ae48f4c756
> >but that is getting a bit too much, and I've downgraded nss for now.
> >
> >The nss update is in wip/nss.
> >
> >Cheers,
> > Thomas
> >
> >slightly annoyed at nss/firefox release engineering
> >
> >On Thu, Nov 19, 2026 at 12:38:57PM +0100, Ryo ONODERA wrote:
> >> Hi,
> >>
> >> On my NetBSD/amd64 11.99.11 laptop, upcomming www/firefox-160.0.1
> >> does not build with nss-3.134.
> >> I suspect firefox-159 has same problem.
> >>
> >> Do you have any fixes for the build failures?
> >>
> >> Thank you.
> >>
> >> "Thomas Klausner" <wiz%netbsd.org@localhost> writes:
> >>
> >> > Module Name: pkgsrc
> >> > Committed By: wiz
> >> > Date: Thu Nov 19 02:49:19 UTC 2026
> >> >
> >> > Modified Files:
> >> > pkgsrc/devel/nss: Makefile PLIST distinfo
> >> > pkgsrc/devel/nss/patches: patch-nss_coreconf_command.mk
> >> >
> >> > Log Message:
> >> > nss: update to 3.134.
> >> >
> >> > Changes:
> >> >
> >> > Bug 2094753 - set bundled NSPR version to 4.41.
> >> > Bug 2090488 - Bind server session cache cert slots to their session by cert hash.
> >> > Bug 2090403 - Select the write cipher spec per record and keep xmitBufLock during the KeyUpdate key change.
> >> > Bug 350261 - softoken should set CKF_WRITE_PROTECTED when NSS is initialized in read-only mode.
> >> > Bug 2093682 - Don't call rmdir inside assert in ScopedUniqueDirectory.
> >> > Bug 2079584 - ML-KEM certificates can only assert keyEncipherment.
> >> > Bug 2093802 - set CKF_USER_PIN_INITIALIZED as appropriate from NSC_GetTokenInfo, not NSC_GetSlotInfo.
> >> > Bug 2090359 - Reject Edwards and Montgomery keys whose CKA_EC_PARAMS name another curve.
> >> > Bug 2090359 - Validate Ed25519 and X25519 private key lengths and defer caching derived public keys.
> >> > Bug 2079584 - support ML-KEM end-entity keys in certutil.
> >> > Bug 2090489 - release cached cert references in the callers of transfer_x_certs_to_collection.
> >> > Bug 2086988 - Free ephemeral key pairs during SSL_ResetHandshake (TLS).
> >> > Bug 2084643 - Add review-context.toml and review guidance for LLM-assisted code review.
> >> > Bug 1592984 - Don't fail a password change on attributes with unverifiable MACs.
> >> > Bug 2087611 - NSS smime: decode the RC2 capability parameter with QuickDER.
> >> > Bug 2092801 - expose MLKEM1024 in tstclnt and selfserv.
> >> > Bug 2092662 - restore websites trust bit and set distrust-after for DigiCert Trusted Root G4.
> >> > Bug 2086204 - Add gtests to exercise OCSP checking in the default SSL_AuthCertificate().
> >> > Bug 2086204 - Remove tstclnt's -F/-M side-channel OCSP verification.
> >> > Bug 2092346 - Don't define mozpkix_ssl in mozpkix-only builds.
> >> > Bug 2068282 - add ML-DSA tests for mozilla::pkix.
> >> > Bug 2068282 - split PublicKeyAlgorithm::MLDSA into one algorithm per parameter set.
> >> > Bug 2068282 - Enable ML-DSA signature verification for certificate chain validation.
> >> > Bug 2068282 - build C++ code as C++17.
> >> > Bug 2086776 - fix error code for zero-length and wrong-length signatures.
> >> > Bug 2087030 - leave a certificate's ID empty if its SPKI can't be decoded.
> >> > Bug 2091600 - Use byte alignment for x86_64 MPI assembly.
> >> > Bug 2081582 - clang-format.
> >> > Bug 2083958 - add android and iOS builds to CI.
> >> > Bug 2083958 - support cross-compiling for android and iOS in build.sh.
> >> > Bug 2081582 - Require prefix matching for permitted directoryName name constraints.
> >> > Bug 2089492 - Clean-up: Use scoped pointers in gtests.
> >> > Bug 2075958 - Fix -Wunused-but-set-global errors with clang 23 in httpserv and selfserv.
> >> > Bug 2089019 - release assert sftkqueue pointer invariants.
> >> > Bug 2089529 - Destroy the peer certificate and SID in GetResumptionTokenInfoWithFlags when alphSelection fails.
> >> > Bug 1562538 - Remove handshake/handshaking members from SSL sockets.
> >> > Bug 2088965 - [Coverity 1704719] Reset freed keys in TlsPrfTest::ClearTempVars.
> >> > Bug 2089738 - Remove libjar.
> >> > Bug 2081503 - add Windows ASAN CI jobs.
> >> > Bug 2089822 - mozilla::pkix: give Constructed an underlying type to avoid enum warnings.
> >> > Bug 2082077 - test that MAC mechanisms reject use of RSA keys.
> >> > Bug 2085902 - Set nssckbi version to 2.94.
> >> > Bug 2089115 - remove email trust and set TLS distrustAfter for emSign Root CA - G1.
> >> > Bug 2088279 - Remove Email Trust Bit from IdenTrust Commercial Root CA 1.
> >> > Bug 2088275 - Remove Email Trust Bit from UCA Global G2 Root.
> >> > Bug 2088266 - Change Trust Bits for DigiCert Global Root G2, G3, G4 and QuoVadis Root CA 1 G3, 3 G3.
> >> > Bug 2085928 - Remove Websites Trust Bit from Certigna Root CA.
> >> > Bug 2085917 - Remove Buypass Class 2 Root CA and Buypass Class 3 Root CA from NSS.
> >> > Bug 2085912 - Set CKA_NSS_SERVER_DISTRUST_AFTER for Firmaprofesional root.
> >> > Bug 2088883 - Report plaintext resumption in SSLResumptionTokenInfo.
> >> > Bug 1892872 - add SSLExp_GetResumptionTokenInfoWithFlags.
> >> > Bug 2088397 - Add clang-23 to CI.
> >> > Bug 2083934 - Use mozpkix to extract the peer certificate's subjectPublicKeyInfo in libssl.
> >> > Bug 2083934 - Add helper to mozpkix to extract subjectPublicKeyInfo.
> >> > Bug 1989541 - Don't disable CK_PKCS5_PBKD2_PARAMS support in fuzzing builds.
> >> >
> >> >
> >> > To generate a diff of this commit:
> >> > cvs rdiff -u -r1.308 -r1.309 pkgsrc/devel/nss/Makefile
> >> > cvs rdiff -u -r1.31 -r1.32 pkgsrc/devel/nss/PLIST
> >> > cvs rdiff -u -r1.222 -r1.223 pkgsrc/devel/nss/distinfo
> >> > cvs rdiff -u -r1.4 -r1.5 \
> >> > pkgsrc/devel/nss/patches/patch-nss_coreconf_command.mk
> >> >
> >> > Please note that diffs are not public domain; they are subject to the
> >> > copyright notices on the relevant files.
> >> >
> >> > Modified files:
> >> >
> >> > Index: pkgsrc/devel/nss/Makefile
> >> > diff -u pkgsrc/devel/nss/Makefile:1.308 pkgsrc/devel/nss/Makefile:1.309
> >> > --- pkgsrc/devel/nss/Makefile:1.308 Wed Nov 11 11:52:49 2026
> >> > +++ pkgsrc/devel/nss/Makefile Thu Nov 19 02:49:18 2026
> >> > @@ -1,10 +1,9 @@
> >> > -# $NetBSD: Makefile,v 1.308 2026/11/11 11:52:49 wiz Exp $
> >> > +# $NetBSD: Makefile,v 1.309 2026/11/19 02:49:18 wiz Exp $
> >> > #
> >> > # Release Notes
> >> > # https://firefox-source-docs.mozilla.org/security/nss/releases/index.html
> >> >
> >> > -DISTNAME= nss-3.132
> >> > -PKGREVISION= 1
> >> > +DISTNAME= nss-3.134
> >> > CATEGORIES= devel security
> >> > MASTER_SITES= ${MASTER_SITE_MOZILLA_ALL:=security/nss/releases/NSS_${PKGVERSION_NOREV:S/./_/g}_RTM/src/}
> >> >
> >> > @@ -20,13 +19,16 @@ CHECK_PORTABILITY_SKIP+= configure
> >> > CTF_SUPPORTED= no # https://smartos.org/bugview/OS-6510
> >> >
> >> > USE_GCC_RUNTIME= yes
> >> > -USE_LANGUAGES= c
> >> > +USE_LANGUAGES= c c++
> >> > USE_TOOLS+= bash:test gmake perl pax pkg-config
> >> > # Fails to detect jobserver on systems where /bin/make and /bin/gmake both
> >> > # exist. This is because nss uses "gmake" explicitly rather than $MAKE to
> >> > # launch subprocesses.
> >> > MAKE_JOBS_SAFE= no
> >> >
> >> > +USE_CC_FEATURES= c99
> >> > +USE_CXX_FEATURES= c++17
> >> > +
> >> > BUILD_DIRS= nss
> >> >
> >> > .include "../../mk/bsd.prefs.mk"
> >> > @@ -134,7 +136,7 @@ MAKE_ENV+= NSS_ENABLE_TLS_1_3=1
> >> > CFLAGS+= -DNSS_NO_GCC48
> >> > .endif
> >> >
> >> > -NSPR_MINIMUM_VERSION= 4.39
> >> > +NSPR_MINIMUM_VERSION= 4.41
> >> >
> >> > PKGCONFIG_OVERRIDE= nss.pc
> >> >
> >> > @@ -160,7 +162,7 @@ INSTALLATION_DIRS= bin include/nss lib/n
> >> >
> >> > INSTALL_CMDS+= certutil cmsutil crlutil derdump makepqg \
> >> > mangle modutil ocspclnt oidcalc p7content p7env p7sign \
> >> > - p7verify pk12util rsaperf shlibsign signtool signver \
> >> > + p7verify pk12util rsaperf shlibsign signver \
> >> > ssltap strsclnt symkeyutil vfychain vfyserv
> >> >
> >> > post-extract:
> >> > @@ -181,16 +183,19 @@ do-install:
> >> >
> >> > # needed if host is not in DNS
> >> > TEST_ENV+= HOST=localhost DOMSUF=localdomain
> >> > -# as of 3.129
> >> > +# adapt for your system, subdirectory of '${WRKSRC}/dist'
> >> > +TEST_ENV+= OBJDIR=NetBSD11.99.11_64_OPT.OBJ
> >> > +# as of 3.134
> >> > # Tests summary:
> >> > # --------------
> >> > -# Passed: 5950
> >> > +# Passed: 6073
> >> > # Failed: 5
> >> > # Failed with core: 0
> >> > # ASan failures: 0
> >> > # UBSan failures: 0
> >> > -# Unknown status: 13
> >> > -# TinderboxPrint:Unknown: 13
> >> > +# Unknown status: 14
> >> > +# TinderboxPrint:Unknown: 14
> >> > +#
> >> > # Failed tests:
> >> > # - STANDARD/ssl
> >> > # - STANDARD/ssl_gtests
> >> >
> >> > Index: pkgsrc/devel/nss/PLIST
> >> > diff -u pkgsrc/devel/nss/PLIST:1.31 pkgsrc/devel/nss/PLIST:1.32
> >> > --- pkgsrc/devel/nss/PLIST:1.31 Fri May 15 17:00:56 2026
> >> > +++ pkgsrc/devel/nss/PLIST Thu Nov 19 02:49:18 2026
> >> > @@ -1,4 +1,4 @@
> >> > -@comment $NetBSD: PLIST,v 1.31 2026/05/15 17:00:56 wiz Exp $
> >> > +@comment $NetBSD: PLIST,v 1.32 2026/11/19 02:49:18 wiz Exp $
> >> > bin/certutil
> >> > bin/cmsutil
> >> > bin/crlutil
> >> > @@ -16,7 +16,6 @@ bin/p7verify
> >> > bin/pk12util
> >> > bin/rsaperf
> >> > bin/shlibsign
> >> > -bin/signtool
> >> > bin/signver
> >> > bin/ssltap
> >> > bin/strsclnt
> >> > @@ -37,9 +36,6 @@ include/nss/cryptoht.h
> >> > include/nss/eccutil.h
> >> > include/nss/ecl-exp.h
> >> > include/nss/hasht.h
> >> > -include/nss/jar-ds.h
> >> > -include/nss/jar.h
> >> > -include/nss/jarfile.h
> >> > include/nss/key.h
> >> > include/nss/keyhi.h
> >> > include/nss/keyt.h
> >> > @@ -48,6 +44,17 @@ include/nss/kyber.h
> >> > include/nss/lowkeyi.h
> >> > include/nss/lowkeyti.h
> >> > include/nss/ml_dsat.h
> >> > +include/nss/mozpkix/Input.h
> >> > +include/nss/mozpkix/Result.h
> >> > +include/nss/mozpkix/Time.h
> >> > +include/nss/mozpkix/nss_scoped_ptrs.h
> >> > +include/nss/mozpkix/pkix.h
> >> > +include/nss/mozpkix/pkixc.h
> >> > +include/nss/mozpkix/pkixcheck.h
> >> > +include/nss/mozpkix/pkixder.h
> >> > +include/nss/mozpkix/pkixnss.h
> >> > +include/nss/mozpkix/pkixtypes.h
> >> > +include/nss/mozpkix/pkixutil.h
> >> > include/nss/nss.h
> >> > include/nss/nssb64.h
> >> > include/nss/nssb64t.h
> >> >
> >> > Index: pkgsrc/devel/nss/distinfo
> >> > diff -u pkgsrc/devel/nss/distinfo:1.222 pkgsrc/devel/nss/distinfo:1.223
> >> > --- pkgsrc/devel/nss/distinfo:1.222 Sat Oct 24 23:49:37 2026
> >> > +++ pkgsrc/devel/nss/distinfo Thu Nov 19 02:49:18 2026
> >> > @@ -1,8 +1,8 @@
> >> > -$NetBSD: distinfo,v 1.222 2026/10/24 23:49:37 ryoon Exp $
> >> > +$NetBSD: distinfo,v 1.223 2026/11/19 02:49:18 wiz Exp $
> >> >
> >> > -BLAKE2s (nss-3.132.tar.gz) = ae8e9e60b37651da28dab314167e2a9fa4f143d8ad1dfc43a8ea928d63bb079a
> >> > -SHA512 (nss-3.132.tar.gz) = 9e0936f1b3f1480351895b371e6571440ff0bfcd0c069f0d558006e07ce870b6bebb440bc96e3e1d45fdd3c288da11c7380f3f69646ab1e3c79311f648ce12f9
> >> > -Size (nss-3.132.tar.gz) = 87788090 bytes
> >> > +BLAKE2s (nss-3.134.tar.gz) = 9e2e05905cb351e36fdfb0628cc1e70040fad09265885bd0bddf92613a2103da
> >> > +SHA512 (nss-3.134.tar.gz) = c615b1fb7be646009c25e1a9d0d1b50833760ad7ff5b717bae58b466937351047841dd4eedb5af3956fdc4c7558276fe969bdde932a0e38869729e124e9677ee
> >> > +Size (nss-3.134.tar.gz) = 87716785 bytes
> >> > SHA1 (patch-md) = ebc903bb19456bfa111fad3c101e3f18168b43b3
> >> > SHA1 (patch-me) = 30aa8b8e22bb687b9c71da40ea9e76b56885d1f8
> >> > SHA1 (patch-mf) = 40e58385fb6f944f463bf00b9aad72bc4ea229d0
> >> > @@ -10,6 +10,6 @@ SHA1 (patch-mn) = 5b79783e48249044be1a90
> >> > SHA1 (patch-nss_cmd_platlibs.mk) = 01f4350de601b29c94e8a791a28daca226866bb6
> >> > SHA1 (patch-nss_cmd_shlibsign_sign.sh) = 7948b7b502a4c148ee185836dde8a84d3aa388af
> >> > SHA1 (patch-nss_coreconf_OpenBSD.mk) = 944f71fcaaa7d5b2b3ed008341b1392a65480f2b
> >> > -SHA1 (patch-nss_coreconf_command.mk) = a7b682d367825b48f8802fa30cee83f10680bb74
> >> > +SHA1 (patch-nss_coreconf_command.mk) = 2bbfa841d90d6bebd82d7b8d30755c7717bb7448
> >> > SHA1 (patch-nss_coreconf_nsinstall_Makefile) = 69981ba7355a4413111754859ef08cbd5e1bf4f4
> >> > SHA1 (patch-nss_lib_freebl_verified_internal_Hacl__Bignum__Base.h) = 52565ef5bab1f37154d4266544144d56a5b95699
> >> >
> >> > Index: pkgsrc/devel/nss/patches/patch-nss_coreconf_command.mk
> >> > diff -u pkgsrc/devel/nss/patches/patch-nss_coreconf_command.mk:1.4 pkgsrc/devel/nss/patches/patch-nss_coreconf_command.mk:1.5
> >> > --- pkgsrc/devel/nss/patches/patch-nss_coreconf_command.mk:1.4 Sat Dec 28 23:04:04 2019
> >> > +++ pkgsrc/devel/nss/patches/patch-nss_coreconf_command.mk Thu Nov 19 02:49:18 2026
> >> > @@ -1,10 +1,10 @@
> >> > -$NetBSD: patch-nss_coreconf_command.mk,v 1.4 2019/12/28 23:04:04 ryoon Exp $
> >> > +$NetBSD: patch-nss_coreconf_command.mk,v 1.5 2026/11/19 02:49:18 wiz Exp $
> >> >
> >> > * Pass CFLAGS from pkgsrc
> >> >
> >> > ---- nss/coreconf/command.mk.orig 2019-12-04 00:03:31.000000000 +0000
> >> > +--- nss/coreconf/command.mk.orig 2026-11-18 20:46:23.000000000 +0000
> >> > +++ nss/coreconf/command.mk
> >> > -@@ -12,7 +12,7 @@ AS = $(CC)
> >> > +@@ -12,7 +12,7 @@ LINK_DLL = $(LD) $(OS_DLLFLAGS) $(DLLFLAGS) $(XLD
> >> > ASFLAGS += $(CFLAGS)
> >> > CCF = $(CC) $(CFLAGS)
> >> > LINK_DLL = $(LD) $(OS_DLLFLAGS) $(DLLFLAGS) $(XLDFLAGS)
> >> > @@ -12,4 +12,4 @@ $NetBSD: patch-nss_coreconf_command.mk,v
> >> > +CFLAGS += $(OPTIMIZER) $(OS_CFLAGS) $(WARNING_CFLAGS) $(XP_DEFINE) \
> >> > $(DEFINES) $(INCLUDES) $(XCFLAGS)
> >> > CSTD = -std=c99
> >> > - CXXSTD = -std=c++11
> >> > + CXXSTD = -std=c++17
> >> >
> >>
> >> --
> >> Ryo ONODERA // ryo%tetera.org@localhost
> >> PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3
>
> --
> Ryo ONODERA // ryo%tetera.org@localhost
> PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB FD1B F404 27FA C7D1 15F3
Home |
Main Index |
Thread Index |
Old Index