pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

CVS commit: pkgsrc/graphics/lcms2



Module Name:    pkgsrc
Committed By:   gdt
Date:           Sun Nov  1 00:48:10 UTC 2026

Modified Files:
        pkgsrc/graphics/lcms2: Makefile

Log Message:
lcmc2: Kludge around upstream declining to fix an alignment bug on sparc

Fix and report from Brandon Applegate via tech-pkg@.


To generate a diff of this commit:
cvs rdiff -u -r1.26 -r1.27 pkgsrc/graphics/lcms2/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/graphics/lcms2/Makefile
diff -u pkgsrc/graphics/lcms2/Makefile:1.26 pkgsrc/graphics/lcms2/Makefile:1.27
--- pkgsrc/graphics/lcms2/Makefile:1.26 Tue May 12 16:09:35 2026
+++ pkgsrc/graphics/lcms2/Makefile      Sun Nov  1 00:48:09 2026
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.26 2026/05/12 16:09:35 gdt Exp $
+# $NetBSD: Makefile,v 1.27 2026/11/01 00:48:09 gdt Exp $
 
 DISTNAME=      lcms2-2.19.1
 CATEGORIES=    graphics
@@ -29,6 +29,21 @@ TEST_TARGET=         check
 # if present.  Therefore, we don't enjoin lcms from finding zlib, but
 # don't include it via bl3.
 
+.include "../../mk/bsd.prefs.mk"
+
+# lcms2's suballocator defaults to sizeof(void *) alignment; 32-bit
+# SPARC needs 8 for doubles (Ghostscript's bundled lcms2mt already
+# does this for sparc).  Perhaps other 32-bit arches need this, and if
+# so someone(tm) could add a define in mk someplace for "double needs
+# more than int alignment, specifically N" and we could use it here;
+# this isn't really about lcms.
+#
+# Upstream declined to add a compile-time conditional to fix this:
+#   https://github.com/mm2/Little-CMS/pull/635
+.if ${MACHINE_ARCH} == "sparc"
+CPPFLAGS+=     -DCMS_PTR_ALIGNMENT=8
+.endif
+
 .include "../../graphics/tiff/buildlink3.mk"
 .include "../../mk/jpeg.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"



Home | Main Index | Thread Index | Old Index