CVS commit: pkgsrc/math/py-xgboost

["Thomas Klausner" <wiz%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   wiz
Date:           Mon Oct 26 07:39:21 UTC 2026

Modified Files:
        pkgsrc/math/py-xgboost: Makefile distinfo
Added Files:
        pkgsrc/math/py-xgboost/patches: patch-cpp__src_src_tree_hist_sampler.h

Log Message:
py-xgboost: fix build on NetBSD

Fix pkglint while here.


To generate a diff of this commit:
cvs rdiff -u -r1.20 -r1.21 pkgsrc/math/py-xgboost/Makefile
cvs rdiff -u -r1.12 -r1.13 pkgsrc/math/py-xgboost/distinfo
cvs rdiff -u -r0 -r1.1 \
    pkgsrc/math/py-xgboost/patches/patch-cpp__src_src_tree_hist_sampler.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/math/py-xgboost/Makefile
diff -u pkgsrc/math/py-xgboost/Makefile:1.20 pkgsrc/math/py-xgboost/Makefile:1.21
--- pkgsrc/math/py-xgboost/Makefile:1.20        Fri Oct 23 12:26:56 2026
+++ pkgsrc/math/py-xgboost/Makefile     Mon Oct 26 07:39:21 2026
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.20 2026/10/23 12:26:56 adam Exp $
+# $NetBSD: Makefile,v 1.21 2026/10/26 07:39:21 wiz Exp $
 
 DISTNAME=      xgboost-3.4.1
 PKGNAME=       ${PYPKGPREFIX}-${DISTNAME}
@@ -15,8 +15,8 @@ DEPENDS+=     ${PYPKGPREFIX}-scipy>=0:../../
 
 USE_CXX_FEATURES=      c++17
 USE_LANGUAGES=         c c++
-USE_TOOLS+=            cmake ninja
-GCC_REQD+=             8.1
+USE_TOOLS+=            cmake
+GCC_REQD+=             8
 
 PYTHON_VERSIONS_INCOMPATIBLE=  311
 

Index: pkgsrc/math/py-xgboost/distinfo
diff -u pkgsrc/math/py-xgboost/distinfo:1.12 pkgsrc/math/py-xgboost/distinfo:1.13
--- pkgsrc/math/py-xgboost/distinfo:1.12        Fri Oct 23 12:26:56 2026
+++ pkgsrc/math/py-xgboost/distinfo     Mon Oct 26 07:39:21 2026
@@ -1,8 +1,9 @@
-$NetBSD: distinfo,v 1.12 2026/10/23 12:26:56 adam Exp $
+$NetBSD: distinfo,v 1.13 2026/10/26 07:39:21 wiz Exp $
 
 BLAKE2s (xgboost-3.4.1.tar.gz) = 17880a805b793941018b40952cf60337e0c89ab5b78cdcaa1066175a5480ff43
 SHA512 (xgboost-3.4.1.tar.gz) = 69450d179c7e0d4056fdfc5060ef4a1f6c42f386fb33ed64fec855b47c8ddfc194958e66865f3304b47faf8798c3a8b40ad0a38ef930d4d52bb049b1f0830403
 Size (xgboost-3.4.1.tar.gz) = 1231819 bytes
 SHA1 (patch-cpp__src_dmlc-core_CMakeLists.txt) = d7365655159fd310c73fa1abbbeb86db88c6f671
 SHA1 (patch-cpp__src_include_xgboost_collective_socket.h) = f6b0cca135d6d8f6086213d6c221db466592287e
+SHA1 (patch-cpp__src_src_tree_hist_sampler.h) = b17cda67611e0a42579c077e32472b8bb7d50ca3
 SHA1 (patch-xgboost_libpath.py) = 39b2538729e5e4408de81534cd2b720ed112775a

Added files:

Index: pkgsrc/math/py-xgboost/patches/patch-cpp__src_src_tree_hist_sampler.h
diff -u /dev/null pkgsrc/math/py-xgboost/patches/patch-cpp__src_src_tree_hist_sampler.h:1.1
--- /dev/null   Mon Oct 26 07:39:22 2026
+++ pkgsrc/math/py-xgboost/patches/patch-cpp__src_src_tree_hist_sampler.h       Mon Oct 26 07:39:21 2026
@@ -0,0 +1,20 @@
+$NetBSD: patch-cpp__src_src_tree_hist_sampler.h,v 1.1 2026/10/26 07:39:21 wiz Exp $
+
+In file included from /tmp/math/py-xgboost/work/xgboost-3.4.1/cpp_src/src/tree/hist/sampler.cc:4:
+/tmp/math/py-xgboost/work/xgboost-3.4.1/cpp_src/src/tree/hist/sampler.h: In function 'float xgboost::tree::SamplingProbability(float, float)':
+/tmp/math/py-xgboost/work/xgboost-3.4.1/cpp_src/src/tree/hist/sampler.h:66:9: error: '::isinf' has not been declared; did you mean 'std::isinf'?
+   66 |   if (::isinf(u)) {
+      |         ^~~~~
+      |         std::isinf
+
+--- cpp_src/src/tree/hist/sampler.h.orig       2026-10-26 07:21:07.904416272 +0000
++++ cpp_src/src/tree/hist/sampler.h
+@@ -63,7 +63,7 @@ XGBOOST_DEVICE inline float SamplingProbability(float 
+ 
+ XGBOOST_DEVICE inline float SamplingProbability(float u, float reg_abs_grad) {
+   // An infinite threshold represents an empty sampling budget exactly.
+-  if (::isinf(u)) {
++  if (std::isinf(u)) {
+     return 0.0f;
+   }
+   if (::fabs(u) < kRtEps) {