CVS commit: pkgsrc/print/poppler

["Patrick Welche" <prlw1%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   prlw1
Date:           Sat Jul  4 21:57:34 UTC 2026

Modified Files:
        pkgsrc/print/poppler: Makefile distinfo
Added Files:
        pkgsrc/print/poppler/patches: patch-glib_poppler-page.cc

Log Message:
poppler: construct missing mutex from upstream commit 08f4bca6a

Fixes exception seen in
https://mail-index.netbsd.org/pkgsrc-users/2026/07/04/msg043149.html
so issue not MacOS specific.


To generate a diff of this commit:
cvs rdiff -u -r1.129 -r1.130 pkgsrc/print/poppler/Makefile
cvs rdiff -u -r1.182 -r1.183 pkgsrc/print/poppler/distinfo
cvs rdiff -u -r0 -r1.1 \
    pkgsrc/print/poppler/patches/patch-glib_poppler-page.cc

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/print/poppler/Makefile
diff -u pkgsrc/print/poppler/Makefile:1.129 pkgsrc/print/poppler/Makefile:1.130
--- pkgsrc/print/poppler/Makefile:1.129 Thu Jun 25 06:45:58 2026
+++ pkgsrc/print/poppler/Makefile       Sat Jul  4 21:57:33 2026
@@ -1,6 +1,7 @@
-# $NetBSD: Makefile,v 1.129 2026/06/25 06:45:58 wiz Exp $
+# $NetBSD: Makefile,v 1.130 2026/07/04 21:57:33 prlw1 Exp $
 
 COMMENT=       PDF rendering library
+PKGREVISION=   1
 
 SUPERSEDES+=   poppler-glib-[0-9]*
 

Index: pkgsrc/print/poppler/distinfo
diff -u pkgsrc/print/poppler/distinfo:1.182 pkgsrc/print/poppler/distinfo:1.183
--- pkgsrc/print/poppler/distinfo:1.182 Wed Jun 24 21:55:29 2026
+++ pkgsrc/print/poppler/distinfo       Sat Jul  4 21:57:33 2026
@@ -1,5 +1,6 @@
-$NetBSD: distinfo,v 1.182 2026/06/24 21:55:29 wiz Exp $
+$NetBSD: distinfo,v 1.183 2026/07/04 21:57:33 prlw1 Exp $
 
 BLAKE2s (poppler-26.06.0.tar.xz) = a9c3f5adca30a26b72903eb8df3a3ca226fe0a1da642e621ec3fc4a48b3ca181
 SHA512 (poppler-26.06.0.tar.xz) = 65ddfed90f07740a1f6ba641db7902ac537bf9d18d7f39de834c15a932dac8f5145552fa44a938a1938cc7424566f1e4fce6371e64b9c5b554e16b55ff5b643b
 Size (poppler-26.06.0.tar.xz) = 2044116 bytes
+SHA1 (patch-glib_poppler-page.cc) = 8373e421a7887ebeb7ab44323d2020c4263bdb45

Added files:

Index: pkgsrc/print/poppler/patches/patch-glib_poppler-page.cc
diff -u /dev/null pkgsrc/print/poppler/patches/patch-glib_poppler-page.cc:1.1
--- /dev/null   Sat Jul  4 21:57:34 2026
+++ pkgsrc/print/poppler/patches/patch-glib_poppler-page.cc     Sat Jul  4 21:57:33 2026
@@ -0,0 +1,26 @@
+$NetBSD: patch-glib_poppler-page.cc,v 1.1 2026/07/04 21:57:33 prlw1 Exp $
+
+PopplerPage instances are created with g_object_new(), which only
+zero-initializes the instance memory and never runs a C++ constructor
+for members. Since commit e3d56a0e ("glib: add a lock in PopplerPage
+to make TextPage computation thread-safe", 26.05.0) the struct gained a
+std::mutex member, but poppler_page_init() was empty, leaving the mutex
+as an all-zero pthread_mutex_t.
+
+https://gitlab.freedesktop.org/poppler/poppler/-/commit/08f4bca6a669f9fce75dbab743db559a86591738
+
+--- glib/poppler-page.cc.orig  2026-06-02 20:32:51.000000000 +0000
++++ glib/poppler-page.cc
+@@ -1134,7 +1134,11 @@ static void poppler_page_class_init(PopplerPageClass *
+     g_object_class_install_property(G_OBJECT_CLASS(klass), PROP_LABEL, g_param_spec_string("label", "Page Label", "The label of the page", nullptr, G_PARAM_READABLE));
+ }
+ 
+-static void poppler_page_init(PopplerPage * /*page*/) { }
++static void poppler_page_init(PopplerPage * page)
++{
++    // GObject zero-initializes instance memory; construct the C++ mutex member explicitly.
++    new (&page->mutex) std::mutex();
++}
+ 
+ /**
+  * poppler_page_get_link_mapping: