CVS commit: pkgsrc/mk/tools

["Greg Troxel" <gdt%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   gdt
Date:           Wed Jul  1 12:02:33 UTC 2026

Modified Files:
        pkgsrc/mk/tools: defaults.mk

Log Message:
mk/tools/defaults.mk: Document that TOOL bash must be >= 4.0

macOS ships bash 3 (despite bash4 being released in 2009), and pkgsrc
had a few accomodations for packages that needed bash where bash 3 did
not work.  pkgsrc no longer uses macOS system bash as a tool, as such
workarounds being in packages is not reasonable.

Requiring system bash >= 5 to allow use as TOOL would seem reasonable,
as bash 5.0 was released in 2019.  However, SmartOS uses bash 4, and
years of bulk builds have turned up no problems from bash 4 as a tool.
Therefore, there is no reason to exclude 4, as the point of setting
minimums is to limit human effort and secondarily reduce needless
machine resource use.

While this commit only adds a comment, it provides a basis to
  - remove any workarounds for bash 3 as a tool
  - disable TOOLS_PLATFORM.bash settings on platforms where bash is < 4
  - add a workaround to a package if it needs TOOL bash but is not ok
    with bash 4

As discussed on tech-pkg@.


To generate a diff of this commit:
cvs rdiff -u -r1.66 -r1.67 pkgsrc/mk/tools/defaults.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/mk/tools/defaults.mk
diff -u pkgsrc/mk/tools/defaults.mk:1.66 pkgsrc/mk/tools/defaults.mk:1.67
--- pkgsrc/mk/tools/defaults.mk:1.66    Wed Jul  3 13:27:16 2024
+++ pkgsrc/mk/tools/defaults.mk Wed Jul  1 12:02:33 2026
@@ -1,4 +1,4 @@
-# $NetBSD: defaults.mk,v 1.66 2024/07/03 13:27:16 cheusov Exp $
+# $NetBSD: defaults.mk,v 1.67 2026/07/01 12:02:33 gdt Exp $
 #
 # Copyright (c) 2005 The NetBSD Foundation, Inc.
 # All rights reserved.
@@ -53,6 +53,7 @@ TOOLS_DEFAULTS_MK=    defined
 
 _TOOLS_VARNAME.awk=            AWK
 _TOOLS_VARNAME.basename=       BASENAME
+# TOOLS_PLATFORM.bash must be >= 4.0.
 _TOOLS_VARNAME.bash=           BASH
 _TOOLS_VARNAME.bison-yacc=     YACC
 _TOOLS_VARNAME.byacc=          YACC