CVS commit: pkgsrc/devel/protobuf

["Greg Troxel" <gdt%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   gdt
Date:           Mon Jun  1 00:02:45 UTC 2026

Modified Files:
        pkgsrc/devel/protobuf: Makefile

Log Message:
devel/protobuf: Stop requiring gcc13

Upstream's bugfix for this is in 35.0, and it builds with gcc10.
Avoiding gcc13 is good just for avoiding, but it also allows qgis4 to
build on NetBSD 10, instead of failing due to the woes of varying
libstdc++.  Leave the comment for now, until we're sure this is fixed.


To generate a diff of this commit:
cvs rdiff -u -r1.106 -r1.107 pkgsrc/devel/protobuf/Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/devel/protobuf/Makefile
diff -u pkgsrc/devel/protobuf/Makefile:1.106 pkgsrc/devel/protobuf/Makefile:1.107
--- pkgsrc/devel/protobuf/Makefile:1.106        Fri May 29 11:59:19 2026
+++ pkgsrc/devel/protobuf/Makefile      Mon Jun  1 00:02:45 2026
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.106 2026/05/29 11:59:19 adam Exp $
+# $NetBSD: Makefile,v 1.107 2026/06/01 00:02:45 gdt Exp $
 #
 # When updating this, please also update devel/py-protobuf.
 #
@@ -23,8 +23,13 @@ USE_CXX_FEATURES=    c++17
 USE_LANGUAGES=         c c++
 FORCE_CXX_STD=         c++17
 
-# https://github.com/protocolbuffers/protobuf/issues/26383
-GCC_REQD+=     13
+# protobuf 34.1 failed to build with gcc <=12 and new abseil:
+#   https://github.com/protocolbuffers/protobuf/issues/26383
+# and thus we set GCC_REQD+=13.  As of 35.0, this is marked fixed in
+# upstream NEWS, and the bug shows that fixes were merged.  Builds on
+# NetBSD 10 with gcc10, which resolves linking failures in qgis4
+# because of varying libstdc++, the usual tale of woe.
+# Leaving this note for gc on July 1, in case this resurfaces somehow.
 
 CMAKE_CONFIGURE_ARGS+= -Dprotobuf_ABSL_PROVIDER=package
 CMAKE_CONFIGURE_ARGS+= -Dprotobuf_BUILD_SHARED_LIBS=ON