Re: CVS commit: pkgsrc/lang/rust

[Ryo ONODERA <ryo%tetera.org@localhost>]

Hi,

"David H. Gutteridge" <david%gutteridge.ca@localhost> writes:

>> Module Name:    pkgsrc
>> Committed By:   ryoon
>> Date:           Sun Jan 18 00:42:57 UTC 2026
>> 
>> Modified Files:
>>         pkgsrc/lang/rust: options.mk
>> 
>> Log Message:
>> lang/rust: Fix build under NetBSD 9
>> 
>> 
>> To generate a diff of this commit:
>> cvs rdiff -u -r1.50 -r1.51 pkgsrc/lang/rust/options.mk
>> 
>> Please note that diffs are not public domain; they are subject to the
>> copyright notices on the relevant files.
>> 
>> Modified files:
>> 
>> Index: pkgsrc/lang/rust/options.mk
>> diff -u pkgsrc/lang/rust/options.mk:1.50
>> pkgsrc/lang/rust/options.mk:1.51
>> --- pkgsrc/lang/rust/options.mk:1.50    Tue Jan 13 20:48:23 2026
>> +++ pkgsrc/lang/rust/options.mk Sun Jan 18 00:42:57 2026
>> @@ -1,4 +1,4 @@
>> -# $NetBSD: options.mk,v 1.50 2026/01/13 20:48:23 wiz Exp $
>> +# $NetBSD: options.mk,v 1.51 2026/01/18 00:42:57 ryoon Exp $
>>  
>>  PKG_OPTIONS_VAR=       PKG_OPTIONS.rust
>>  PKG_SUPPORTED_OPTIONS+=        rust-cargo-static rust-docs
>> @@ -87,6 +87,10 @@ CONFIGURE_ARGS+=     --enable-cargo-native-s
>>  BUILDLINK_API_DEPENDS.nghttp2+= nghttp2>=1.41.0
>>  BUILDLINK_API_DEPENDS.curl+=   curl>=7.67.0
>>  .include "../../www/curl/buildlink3.mk"
>> +BUILDLINK_API_DEPENDS.openssl= openssl>=3
>> +RUSTFLAGS+=     -C link-arg=-L${BUILDLINK_PREFIX.openssl}/lib
>> +RUSTFLAGS+=     -C link-
>> arg=${COMPILER_RPATH_FLAG}${BUILDLINK_PREFIX.openssl}/lib
>> +MAKE_ENV+=     RUSTFLAGS=${RUSTFLAGS:Q}
>>  .include "../../security/openssl/buildlink3.mk"
>>  .endif
>> 
>
> Hi,
>
> I've fixed this differently (more generally) in www/curl itself. I don't
> think this fragment is needed anymore in rust and would like to remove
> it. I've tested builds of Rust 1.91.1 on NetBSD 9.4_STABLE both in a
> sandboxed pbulk environment and just with "make package", and both (now)
> succeeded without this. Please let me know if you have any concerns.

I confiormed BUILDLINK_API_DEPENDS.openssl is included
in www/curl/buildlink3.mk.
I believe that removing BUILDLINK_API_DEPENDS.openssl from
lang/rust/Makefile safely.
Please remove it.

In my case, options.mk has additional RUSTFLAGS to link the correct libraries
from pkgsrc OpenSSL.
If your www/curl change ensures the effect of RUSTFLAGS too.
Is there any evidence and explanation for successful build under NetBSD/i386 9?

Thank you.

> Regards,
>
> Dave

-- 
Ryo ONODERA // ryo%tetera.org@localhost
PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3