CVS commit: pkgsrc/textproc/lowdown

["David H. Gutteridge" <gutteridge%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   gutteridge
Date:           Wed Nov 19 14:36:03 UTC 2025

Modified Files:
        pkgsrc/textproc/lowdown: Makefile
        pkgsrc/textproc/lowdown/patches: patch-Makefile

Log Message:
lowdown: fix builds on platforms that require compat functions

Addresses PR pkg/59614 from Piper McCorkle (Linux) and PR pkg/59619
from db7%mini.fritz.box@localhost (macOS).


To generate a diff of this commit:
cvs rdiff -u -r1.36 -r1.37 pkgsrc/textproc/lowdown/Makefile
cvs rdiff -u -r1.7 -r1.8 pkgsrc/textproc/lowdown/patches/patch-Makefile

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/textproc/lowdown/Makefile
diff -u pkgsrc/textproc/lowdown/Makefile:1.36 pkgsrc/textproc/lowdown/Makefile:1.37
--- pkgsrc/textproc/lowdown/Makefile:1.36       Tue Nov 18 08:45:25 2025
+++ pkgsrc/textproc/lowdown/Makefile    Wed Nov 19 14:36:03 2025
@@ -1,6 +1,7 @@
-# $NetBSD: Makefile,v 1.36 2025/11/18 08:45:25 wiz Exp $
+# $NetBSD: Makefile,v 1.37 2025/11/19 14:36:03 gutteridge Exp $
 
 DISTNAME=              lowdown-2.0.4
+PKGREVISION=           1
 CATEGORIES=            textproc
 MASTER_SITES=          ${MASTER_SITE_GITHUB:=kristapsdz/}
 GITHUB_TAG=            refs/tags/VERSION_${PKGVERSION_NOREV:S/./_/g}

Index: pkgsrc/textproc/lowdown/patches/patch-Makefile
diff -u pkgsrc/textproc/lowdown/patches/patch-Makefile:1.7 pkgsrc/textproc/lowdown/patches/patch-Makefile:1.8
--- pkgsrc/textproc/lowdown/patches/patch-Makefile:1.7  Wed Nov 19 09:09:39 2025
+++ pkgsrc/textproc/lowdown/patches/patch-Makefile      Wed Nov 19 14:36:03 2025
@@ -1,7 +1,10 @@
-$NetBSD: patch-Makefile,v 1.7 2025/11/19 09:09:39 wiz Exp $
+$NetBSD: patch-Makefile,v 1.8 2025/11/19 14:36:03 gutteridge Exp $
 
 Libtoolize for portable shared libraries.
 
+Don't "avoid exporting internal functions", as this causes any necessary
+compat functions to fail to link when generating the program itself. 
+
 --- Makefile.orig      2025-11-17 03:25:46.000000000 +0000
 +++ Makefile
 @@ -1,5 +1,6 @@
@@ -11,7 +14,16 @@ Libtoolize for portable shared libraries
  
  include Makefile.configure
  WWWDIR                 = /var/www/vhosts/kristaps.bsd.lv/htdocs/lowdown
-@@ -189,7 +190,12 @@ REGRESS_ARGS      += "--parse-no-deflists"
+@@ -169,8 +170,6 @@ LIB_SOVER   = liblowdown.$(LINKER_SOSUFFI
+ 
+ # Because the objects will be compiled into a shared library:
+ CFLAGS                += -fPIC
+-# To avoid exporting internal functions (lowdown.h has default visibility).
+-CFLAGS                += -fvisibility=hidden
+ 
+ # Only for MarkdownTestv1.0.3 in regress/original.
+ 
+@@ -189,7 +188,12 @@ REGRESS_ARGS      += "--parse-no-deflists"
  
  REGRESS_ENV    = LC_ALL=en_US.UTF-8
  
@@ -25,7 +37,7 @@ Libtoolize for portable shared libraries
  bins: lowdown lowdown-diff
  
  www: all $(HTMLS) $(PDFS) $(THUMBS) lowdown.tar.gz lowdown.tar.gz.sha512
-@@ -202,15 +208,20 @@ installwww: www
+@@ -202,15 +206,20 @@ installwww: www
        $(INSTALL) -m 0444 lowdown.tar.gz $(WWWDIR)/snapshots
        $(INSTALL) -m 0444 lowdown.tar.gz.sha512 $(WWWDIR)/snapshots
  
@@ -49,7 +61,7 @@ Libtoolize for portable shared libraries
  $(LIB_SO): $(OBJS) $(COMPAT_OBJS)
        $(CC) $(LINKER_SOFLAG) -o $(LIB_SOVER) $(OBJS) $(COMPAT_OBJS) \
                $(LDFLAGS) $(LDADD_MD5) -lm \
-@@ -240,8 +251,8 @@ install: bins
+@@ -240,8 +249,8 @@ install: bins
        $(INSTALL_DATA) share/man/* $(DESTDIR)$(SHAREDIR)/lowdown/man
        $(INSTALL_DATA) share/ms/* $(DESTDIR)$(SHAREDIR)/lowdown/ms
        $(INSTALL_DATA) share/odt/* $(DESTDIR)$(SHAREDIR)/lowdown/odt
@@ -60,7 +72,7 @@ Libtoolize for portable shared libraries
        for f in $(MAN1S) $(MAN5S) ; do \
                name=`basename $$f .html` ; \
                section=$${name##*.} ; \
-@@ -272,6 +283,9 @@ install_lib_common: lowdown.pc
+@@ -272,6 +281,9 @@ install_lib_common: lowdown.pc
  uninstall_shared: uninstall_lib_common
        rm -f $(LIBDIR)/$(LIB_SOVER) $(LIBDIR)/$(LIB_SO)
  
@@ -70,7 +82,7 @@ Libtoolize for portable shared libraries
  install_shared: $(LIB_SO) install_lib_common
        $(INSTALL_LIB) $(LIB_SOVER) $(DESTDIR)$(LIBDIR)
        ( cd $(DESTDIR)$(LIBDIR) && ln -sf $(LIB_SOVER) $(LIB_SO) )
-@@ -344,6 +358,9 @@ diff.diff.pdf: diff.md diff.old.md lowdo
+@@ -344,6 +356,9 @@ diff.diff.pdf: diff.md diff.old.md lowdo
  
  $(HTMLS): versions.xml lowdown
  
@@ -80,7 +92,7 @@ Libtoolize for portable shared libraries
  .md.xml: lowdown
        ( echo "<?xml version=\"1.0\" encoding=\"UTF-8\" ?>" ; \
          echo "<article data-sblg-article=\"1\">" ; \
-@@ -396,13 +413,13 @@ lowdown.tar.gz:
+@@ -396,13 +411,13 @@ lowdown.tar.gz:
        ( cd .dist/ && tar zcf ../$@ lowdown-$(VERSION) )
        rm -rf .dist/