CVS commit: pkgsrc/www/firefox128

["Leonardo Taccari" <leot%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   leot
Date:           Thu Sep 11 14:42:22 UTC 2025

Modified Files:
        pkgsrc/www/firefox128: Makefile distinfo
Added Files:
        pkgsrc/www/firefox128/patches: patch-gfx_ots_src_name.cc

Log Message:
firefox128: Fix a ctype(3) abuse

Noticed while visiting
<https://developer.hashicorp.com/terraform/cli/commands/0.13upgrade>.

PKGREVISION++


To generate a diff of this commit:
cvs rdiff -u -r1.30 -r1.31 pkgsrc/www/firefox128/Makefile
cvs rdiff -u -r1.19 -r1.20 pkgsrc/www/firefox128/distinfo
cvs rdiff -u -r0 -r1.1 \
    pkgsrc/www/firefox128/patches/patch-gfx_ots_src_name.cc

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/www/firefox128/Makefile
diff -u pkgsrc/www/firefox128/Makefile:1.30 pkgsrc/www/firefox128/Makefile:1.31
--- pkgsrc/www/firefox128/Makefile:1.30 Sat Aug 30 22:46:30 2025
+++ pkgsrc/www/firefox128/Makefile      Thu Sep 11 14:42:22 2025
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.30 2025/08/30 22:46:30 wiz Exp $
+# $NetBSD: Makefile,v 1.31 2025/09/11 14:42:22 leot Exp $
 
 FIREFOX_VER=           ${MOZ_BRANCH}${MOZ_BRANCH_MINOR}
 MOZ_BRANCH=            128.14
@@ -6,7 +6,7 @@ MOZ_BRANCH_MINOR=       .0esr
 
 DISTNAME=      firefox-${FIREFOX_VER}.source
 PKGNAME=       ${DISTNAME:S/.source//:S/b/beta/:S/esr//:S/firefox-/firefox128-/}
-PKGREVISION=   1
+PKGREVISION=   2
 CATEGORIES=    www
 MASTER_SITES+= ${MASTER_SITE_MOZILLA:=firefox/releases/${FIREFOX_VER}/source/}
 MASTER_SITES+= ${MASTER_SITE_MOZILLA_ALL:=firefox/releases/${FIREFOX_VER}/source/}

Index: pkgsrc/www/firefox128/distinfo
diff -u pkgsrc/www/firefox128/distinfo:1.19 pkgsrc/www/firefox128/distinfo:1.20
--- pkgsrc/www/firefox128/distinfo:1.19 Sun Aug 24 04:51:23 2025
+++ pkgsrc/www/firefox128/distinfo      Thu Sep 11 14:42:22 2025
@@ -1,4 +1,4 @@
-$NetBSD: distinfo,v 1.19 2025/08/24 04:51:23 gutteridge Exp $
+$NetBSD: distinfo,v 1.20 2025/09/11 14:42:22 leot Exp $
 
 BLAKE2s (firefox-128.14.0esr.source.tar.xz) = a3cc3c29528e11e4a25d67ac536bc00bdb09aaaddb21f36586e9a30a1dc412cb
 SHA512 (firefox-128.14.0esr.source.tar.xz) = a3cf267e82b6f5ab8b6497a62b12f85afb78fcaef6b12c43ef79564ce8270d3327a873368ce48fc018e46fef5e07339c07b9a494a5ff6c22a84099f939f6a9de
@@ -15,6 +15,7 @@ SHA1 (patch-dom_base_nsAttrName.h) = ac7
 SHA1 (patch-dom_webtransport_api_WebTransportDatagramDuplexStream.cpp) = b93b4c6367bd2fb3d1868ab7d97ca56c100be414
 SHA1 (patch-gfx_angle_checkout_src_common_third__party_smhasher_src_PMurHash.cpp) = e458c9c8dc66edc69c1874734af28a77fc5e3993
 SHA1 (patch-gfx_angle_checkout_src_compiler_translator_InfoSink.h) = b2adce9e65662283a11b6dcff40e95523e940045
+SHA1 (patch-gfx_ots_src_name.cc) = b3ea28fa953e2918d86ece58c4f0db6a389db21f
 SHA1 (patch-gfx_wr_swgl_build.rs) = df6ebfaabb4d27994e59a9d0eaf12c7cf08415fb
 SHA1 (patch-intl_lwbrk_LineBreaker.cpp) = e2eaf7d66f1255ba5baf7f7edadbb1fa8cb39b13
 SHA1 (patch-ipc_chromium_src_base_message__pump__libevent.cc) = 298642a3527804115b398fb7904a3596962932e3

Added files:

Index: pkgsrc/www/firefox128/patches/patch-gfx_ots_src_name.cc
diff -u /dev/null pkgsrc/www/firefox128/patches/patch-gfx_ots_src_name.cc:1.1
--- /dev/null   Thu Sep 11 14:42:22 2025
+++ pkgsrc/www/firefox128/patches/patch-gfx_ots_src_name.cc     Thu Sep 11 14:42:22 2025
@@ -0,0 +1,15 @@
+$NetBSD: patch-gfx_ots_src_name.cc,v 1.1 2025/09/11 14:42:22 leot Exp $
+
+Fix ctype(3) abuses.
+
+--- gfx/ots/src/name.cc.orig   2025-09-11 14:28:47.940108735 +0000
++++ gfx/ots/src/name.cc
+@@ -16,7 +16,7 @@ namespace {
+ // We disallow characters outside the URI spec "unreserved characters"
+ // set; any chars outside this set will be replaced by underscore.
+ bool AllowedInPsName(char c) {
+-  return isalnum(c) || std::strchr("-._~", c);
++  return isalnum((unsigned char)c) || std::strchr("-._~", c);
+ }
+ 
+ bool SanitizePsNameAscii(std::string& name) {