CVS commit: pkgsrc/mk/compiler

["Roland Illig" <rillig%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   rillig
Date:           Wed Jul  9 17:43:50 UTC 2025

Modified Files:
        pkgsrc/mk/compiler: gcc.mk

Log Message:
mk/gcc.mk: don't pass "$" characters through a .for loop

Passing the expression "${.TARGET:H}" through the :S modifier relies on
the expression being preserved. This only works because the expression
is evaluated outside the context of a target.

Passing the same expression through the .for loop relies on undocumented
behavior of the .for loop, in that a "$" of an expression is not
escaped but preserves the expression.


To generate a diff of this commit:
cvs rdiff -u -r1.292 -r1.293 pkgsrc/mk/compiler/gcc.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/mk/compiler/gcc.mk
diff -u pkgsrc/mk/compiler/gcc.mk:1.292 pkgsrc/mk/compiler/gcc.mk:1.293
--- pkgsrc/mk/compiler/gcc.mk:1.292     Tue Jul  1 19:54:34 2025
+++ pkgsrc/mk/compiler/gcc.mk   Wed Jul  9 17:43:50 2025
@@ -1,4 +1,4 @@
-# $NetBSD: gcc.mk,v 1.292 2025/07/01 19:54:34 dkazankov Exp $
+# $NetBSD: gcc.mk,v 1.293 2025/07/09 17:43:50 rillig Exp $
 #
 # This is the compiler definition for the GNU Compiler Collection.
 #
@@ -1296,10 +1296,10 @@ ${_GCC_${_var_}}:
        ) > ${.TARGET}
        ${RUN}${CHMOD} +x ${.TARGET}
 .    endif
-.    for _alias_ in ${_ALIASES.${_var_}:S/^/${.TARGET:H}\//}
-       ${RUN}                                  \
-       if [ ! -x "${_alias_}" ]; then                                  \
-               ${LN} -f -s ${.TARGET:T} ${_alias_};                    \
+.    for _alias_ in ${_ALIASES.${_var_}}
+       ${RUN}                                                          \
+       if [ ! -x "${.TARGET:H}/${_alias_}" ]; then                     \
+               ${LN} -f -s ${.TARGET:T} ${.TARGET:H}/${_alias_};       \
        fi
 .    endfor
 .  endif