Re: CVS commit: pkgsrc/cad

[nia <nia%NetBSD.org@localhost>]

On Wed, Jul 19, 2023 at 07:35:47AM -0400, Greg Troxel wrote:
> What I think is not ok is:
> 
>   USE_LANGUAGES+=c++17
> 
> leading to
> 
>   USE_LANGUAGES+=c++
> 
> without adding to USE_CXX_FEATURES, because that drops the information
> that a c++17 compiler is required -- even if it never forced it -- and
> it has the unintended effect of not failing early due to --std being
> inserted, and instead relying on the compiler throwing errors from
> constructs that are not c++03.
> 
> On rereading the current state of kicad, I see c++17 is still in
> USE_LANGUAGES, so that's merely an incomplete conversion, on the basis
> of caution that it might require std forcing.
> 
> Is that the way you see it?

Yes, I entirely agree with everything here.