Re: CVS commit: pkgsrc/devel/gettext-lib

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Thu, Jun 29, 2023 at 08:24:19AM +0000, Adam Ciarcinski wrote:
> Index: pkgsrc/devel/gettext-lib/builtin.mk
> diff -u pkgsrc/devel/gettext-lib/builtin.mk:1.49 pkgsrc/devel/gettext-lib/builtin.mk:1.50
> --- pkgsrc/devel/gettext-lib/builtin.mk:1.49  Thu Oct 15 23:32:07 2020
> +++ pkgsrc/devel/gettext-lib/builtin.mk       Thu Jun 29 08:24:19 2023
> @@ -60,12 +60,12 @@ USE_BUILTIN.gettext=      no
>  .  else
>  USE_BUILTIN.gettext= ${IS_BUILTIN.gettext}
>  .    if defined(BUILTIN_PKG.gettext) && \
> -     !empty(IS_BUILTIN.gettext:M[yY][eE][sS])
> +     ${IS_BUILTIN.gettext:tl} == yes
>  USE_BUILTIN.gettext= yes
>  .      for _dep_ in ${BUILDLINK_API_DEPENDS.gettext}
> -.        if !empty(USE_BUILTIN.gettext:M[yY][eE][sS])
> +.        if ${USE_BUILTIN.gettext:tl} == yes
>  USE_BUILTIN.gettext!=                                                        \
> -     if ${PKG_ADMIN} pmatch ${_dep_:Q} ${BUILTIN_PKG.gettext:Q}; then \
> +     if ${PKG_ADMIN} pmatch ${_dep_:Q} ${BUILTIN_PKG.gettext}; then  \
>               ${ECHO} yes;                                            \
>       else                                                            \
>               ${ECHO} no;                                             \

Ignoring all the annoying stylistic changes in this diff, the removal of
the :Q here doesn't look correct.

Joerg