Re: CVS commit: pkgsrc/comms/libhidapi

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Wed, May 10, 2023 at 04:56:38PM +0000, Nikita wrote:
> Module Name:  pkgsrc
> Committed By: nikita
> Date:         Wed May 10 16:56:38 UTC 2023
> 
> Modified Files:
>       pkgsrc/comms/libhidapi: Makefile PLIST distinfo
> 
> Log Message:
> libhidapi: update to version 0.13.1

This update changes the library name from libhidapi to libhidapi-libusb:

> Index: pkgsrc/comms/libhidapi/PLIST
> diff -u pkgsrc/comms/libhidapi/PLIST:1.4 pkgsrc/comms/libhidapi/PLIST:1.5
> --- pkgsrc/comms/libhidapi/PLIST:1.4  Tue Dec  7 16:42:13 2021
> +++ pkgsrc/comms/libhidapi/PLIST      Wed May 10 16:56:38 2023
> @@ -1,11 +1,11 @@
> -@comment $NetBSD: PLIST,v 1.4 2021/12/07 16:42:13 jperkin Exp $
> +@comment $NetBSD: PLIST,v 1.5 2023/05/10 16:56:38 nikita Exp $
>  include/hidapi/hidapi.h
>  ${PLIST.libusb}include/hidapi/hidapi_libusb.h
> -lib/libhidapi.la
> -lib/pkgconfig/hidapi.pc
> -share/doc/hidapi/AUTHORS.txt
> -share/doc/hidapi/LICENSE-bsd.txt
> -share/doc/hidapi/LICENSE-gpl3.txt
> -share/doc/hidapi/LICENSE-orig.txt
> -share/doc/hidapi/LICENSE.txt
> -share/doc/hidapi/README.md
> +lib/cmake/hidapi/hidapi-config-version.cmake
> +lib/cmake/hidapi/hidapi-config.cmake
> +lib/cmake/hidapi/libhidapi-release.cmake
> +lib/cmake/hidapi/libhidapi.cmake
> +lib/libhidapi-libusb.so
> +lib/libhidapi-libusb.so.0
> +lib/libhidapi-libusb.so.0.13.1
> +lib/pkgconfig/hidapi-libusb.pc

Please bump ABI depends in the buildlink3.mk and revbump all packages using it.

Please also take a look at devel/openocd which broke after the update:

libtool: link: ranlib src/.libs/libopenocd.a
libtool: link: rm -fr src/.libs/libopenocd.lax src/.libs/libopenocd.lax
libtool: link: ( cd "src/.libs" && rm -f "libopenocd.la" && ln -s "../libopenocd.la" "libopenocd.la" )
/bin/sh ./libtool  --tag=CC   --mode=link gcc -Wall -Wstrict-prototypes -Wformat-security -Wshadow -Wextra -Wno-unused-parameter -Wbad-function-cast -Wcast-align -Wredundant-decls -Wpointer-arith 
-Werror -O2 -g -fPIC -D_FORTIFY_SOURCE=2 -fstack-clash-protection -I/usr/pkg/include -I/usr/include  -Wl,-zrelro -Wl,-znow -L/usr/pkg/lib -Wl,-R/usr/pkg/lib -L/usr/lib -Wl,-R/usr/lib -o src/openocd 
src/main.o src/libopenocd.la   $(pkg-config --libs jimtcl) -lutil 
libtool: link: gcc -Wall -Wstrict-prototypes -Wformat-security -Wshadow -Wextra -Wno-unused-parameter -Wbad-function-cast -Wcast-align -Wredundant-decls -Wpointer-arith -O2 -g -fPIC 
-D_FORTIFY_SOURCE=2 -fstack-clash-protection -I/scratch/devel/openocd/work/.buildlink/include -Wl,-zrelro -Wl,-znow -Wl,-rpath -Wl,/usr/pkg/lib -o src/openocd src/main.o -pie  
-L/scratch/devel/openocd/work/.buildlink/lib src/.libs/libopenocd.a -lusb -lftdi1 -lhidapi -lusb-1.0 -lpthread -lm -lcapstone -ljim -lutil -pthread 
-Wl,-rpath,/scratch/devel/openocd/work/.buildlink/lib -Wl,-rpath,/scratch/devel/openocd/work/.buildlink/lib
ld: cannot find -lhidapi: No such file or directory
gmake[2]: *** [Makefile:3208: src/openocd] Error 1


Thank you!
 Thomas