Re: CVS commit: [pkgsrc-2022Q4] pkgsrc/converters/wkhtmltopdf

[Taylor R Campbell <campbell+netbsd-pkgsrc-changes%mumble.net@localhost>]

> Module Name:    pkgsrc
> Committed By:   manu
> Date:           Fri Jan 20 16:20:43 UTC 2023
> 
> Modified Files:
>         pkgsrc/converters/wkhtmltopdf [pkgsrc-2022Q4]: Makefile distinfo
>         pkgsrc/converters/wkhtmltopdf/patches [pkgsrc-2022Q4]:
>             patch-src_image_image.pro patch-src_lib_lib.pro
>             patch-src_pdf_pdf.pro
> 
> Log Message:
> Fix converters/wkhtmltopdf build
> 
> The package checks choked on missing -R/usr/X11R7/lib

Did you mean to commit this on HEAD instead of pkgsrc-2022Q4?  I think
this should be reverted -- and a pullup submitted if you want it to
appear on 2022Q4, but it probably needs some fixing first:

> diff -u pkgsrc/converters/wkhtmltopdf/Makefile:1.14 pkgsrc/converters/wkhtmltopdf/Makefile:1.14.4.1
> --- pkgsrc/converters/wkhtmltopdf/Makefile:1.14 Thu Jun 30 11:18:08 2022
> +++ pkgsrc/converters/wkhtmltopdf/Makefile      Fri Jan 20 16:20:42 2023
> [...]
> +CXXFLAHS+=     {COMPILER_RPATH_FLAG}${X11BASE}/lib

I don't think this is going to do what you want to do.  There's a
missing $ before {COMPILER_RPATH_FLAG}, so it won't be expanded, but
this probably won't have any effect anyway because you set CXXFLAHS
instead of CXXFLAGS (H instead of G).