pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/lang/ruby



Am Sat, Sep 03, 2022 at 03:05:03PM +0100 schrieb Jonathan Perkin:
> * On 2022-09-03 at 14:15 BST, Takahiro Kambe wrote:
> 
> > Log Message:
> > lang/ruby/rails.mk: use expr instead of ${EXPR}
> > 
> > Since rails.mk might be used before ${EXPR} is defined, use expr
> > instead of ${EXPR}.
> 
> There's no guarantee that whatever "expr" happens to be first in PATH will
> be the correct one.  You can ensure the variable will be evaluated correctly
> by using the:
> 
>       RAILS_NEXT_cmd= ${EXPR} ...
>       SOMETHING= ${RAILS_NEXT_cmd:sh}
> 
> style instead.

Can't we just use:

RAILS_NEXT_cmd= echo $$(( ... ))

here and side-step the whole expr use? We should be requiring a shell
that supports arithmetic expansion anyway?

Joerg



Home | Main Index | Thread Index | Old Index