pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/mail/milter-greylist



Hauke Fath <hauke%Espresso.Rhein-Neckar.DE@localhost> writes:

> On Thu, 30 Jun 2022 10:57:35 -0400, Greg Troxel wrote:
>> Please include a summary of upstream NEWS (or what upstream should have
>> put in NEWS, for NEWS_deficient upstreams).
>
> There is nothing on the web page, but I see now the package has a 
> ChangeLog file, which lists fixes to crashing bugs and buffer 
> overflows. I'll include it in the pullup request. 
>
>> I was not aware of breakage; it built fine for me on NetBSD 9 amd64.
>
> Good. On a netbsd-9 KVM installation, configure broke over missing 
> symbols in libmilter. In the end, this looked like a stale libmilter, 
> and re-installing it made milter-greylist build.

Please make sure the pullup is then justifiable on security fixes only,
as it seems like your build failure was spurious.  (I don't mean to
criticize the update at all - that's great to see.)

We rarely pull up big version jumps like this; please skim the upstream
diff to look for things that could cause it to fail on systems you
haven't tested on.  It did built on 9/i386, 9/earmv7hf-el.  On macOS
10.13/x86_64, the old version failed and the new one built.  That's only
2 of about 10 operating systems; would be nice if someone can try it on
illumos and GNU/Linux.  Waiting a week and checking bulk builds seems
like a good way to do that.




Attachment: signature.asc
Description: PGP signature



Home | Main Index | Thread Index | Old Index