CVS commit: pkgsrc/textproc/xapian

["Amitai Schleier" <schmonz%netbsd.org@localhost>]

Module Name:    pkgsrc
Committed By:   schmonz
Date:           Sun Jan  2 09:31:20 UTC 2022

Modified Files:
        pkgsrc/textproc/xapian: Makefile.common distinfo

Log Message:
Update to 1.4.19. From the changelog:

API:

* New QueryParser::FLAG_NO_POSITIONS flag.  With this flag enabled, any query
  operations which would use positional information are replaced by the nearest
  equivalent which doesn't (so phrase searches, NEAR and ADJ will result in
  OP_AND).  This is intended to replace the automatic conversion of OP_PHRASE,
  etc to OP_AND when a database has no positional information, which will no
  longer happen in the release series after 1.4.

* Give a compile error for code which adds a Database to WritableDatabase.

  Prior to 1.4.19, this compiled and effectively created a "black-hole" shard
  which quietly discarded any changes made to it.

  In 1.4.19 it's still possible to perform this operation by assigning the
  WritableDatabase to a Database first, which is harder to fix.  This case
  throws an exception on git master where it's easier to address.

  Reported by David Bremner on #xapian.

* Fix TermIterator::skip_to() with sharded databases which sometimes was
  failing to advance all the way to the requested term.  Uncovered while
  addressing warning from GCC's -Wduplicated-cond, reported by dcb in #816.

* Clamp edit distance to one less than the length of the word we've been asked
  to correct, which makes the algorithm we use more efficient.  We already
  require suggestion to have at least one character in common, so the only
  change to suggestions is we'll no longer suggest corrections which are
  twice as long or longer even if the edit distance would allow it, which
  seems like an improvement in itself.

* Minor optimisation expanding wildcards.

* PostingIterator::get_description(): For an all-docs iterator on a glass
  database, get_description() would call get_docid() which isn't valid to
  do once the iterator has reached the end.

testsuite:

* Expand allterms test coverage.

matcher:

* Fetch wdf upper bound from postlist which avoids an extra postlist table
  cursor seek per weighted query term, and also means we now use a per-shard
  wdf upper bound for local shards which will in typically give a tighter
  weight upper bound which will tend to make various other matcher
  optimisations more effective.  Eric Wong reported this speeds up a
  particularly slow case from ~2 minutes to ~3 seconds.

  With this change, OP_ELITE_SET can now select a different subset of terms for
  each shard regardless of shard type (previously this only happened for remote
  shards).

* Avoid triggering a pointless maximum weight recalculation if an unweighted
  child of a MultiAndPostList prunes.

* Only check if the database has positional information when the query
  uses positional information.  This should help improve notmuch delete
  performance.  Thanks to andreas on #notmuch for analysis of the problem.

glass backend:

* Optimise Glass::Inverter::has_positions().  Use const auto& instead of just
  auto for the loop variables.  Reported to be faster by andreas on #notmuch.

* Cache result of Glass::Inverter::has_positions() since calculating it is
  potentially very expensive, while maintaining a cached answer is very cheap.

remote backend:

* Add missing closing parenthesis to reported remote prog context, which has
  been missing since this code was first added over 20 years ago!  Spotted by
  Gaurav Arora.

build system:

* Enable compiler option -fno-semantic-interposition if supported.

  This GCC option allows the compiler to optimise essentially assuming
  that functions/variables aren't replaced at dynamic link time.

  Such replacement is not something that it's useful to do for Xapian
  symbols, and we already turn on -Bsymbolic-functions by default which
  prevents such replacement anyway by resolving references within the
  library at build time.

  Reduces the size of the stripped library on x86-64 Debian unstable by
  ~1%, and likely makes it faster too.

* Avoid bogus deprecation warning when compiling with GCC without optimisation.
  In this situation, GCC emits a deprecation warning for code in the definition
  of QueryParser::add_valuerangeprocessor() which is provided for backwards
  API compatibility even if this method is never used anywhere.

  This isn't helpful, especially if the user is using -Werror, so disable the
  -Wdeprecated-deprecations warning for this code.

  Reported by starmad on #xapian.

* Fix GCC -Wmaybe-uninitialized warning.  The warning seems bogus as it's about
  the this pointer being passed to a method which doesn't reference the object,
  but we can just make the method static to avoid the warning, and that's
  arguably cleaner for a method called from the object initialiser list.

* Automatically enable GCC warnings -Wduplicated-cond and -Wduplicated-branches
  if using a GCC version new enough to support them.  The usefulness of
  -Wduplicated-cond was highlighted by dcb in #816.

* Replace uses of obsolete autoconf macros, fixing warnings if configure is
  regenerated with a recent release of autoconf.

* Simplify configure probe for sigsetjmp and siglongjmp.  Just probe
  individually with AC_CHECK_DECLS and then check that both exist with a
  preprocessor check.

* Update XO_LIB_XAPIAN to fix warning that AC_ERROR is obsolete with modern
  autoconf.

* Support linking against static libxapian with cmake. Patch from Anonymous
  Maarten in https://github.com/xapian/xapian/pull/317

* Clean up handling of libs we link libxapian with - previously any libraries
  explicitly specified to configure by the user via LIBS=... as well as -lm
  (if configure determined it was needed) could get added to XAPIAN_LIBS
  multiple times, as well as also getting added to the libxapian link command
  anyway by automake/libtool standard handling.

  Specifying a library more than once on the link line is not a problem on
  common platforms, but may be an issue somewhere (and it's on less common
  platforms where the user is more likely to have to specify LIBS to configure
  and/or where -lm may be needed).

documentation:

* configure: Add missing AC_ARG_VAR for all programs so that they are
  documented in --help output, and so that autoconf knows they are "precious"
  and preserves them if configure is rerun even when they're specified via an
  environment variable.

* Don't use x^2 to mean x squared in API docs.  This is potentially confusing
  since in C/C++ (and some other languages), ^ means exclusive-or.  Write x²
  instead, which should be clear to all readers.

* Improve docs for Xapian::Stopper and SimpleStopper.

* docs/intro_ir.rst: Fixed an incorrect term index.  Patch from Jaak Ristioja
  in https://github.com/xapian/xapian/pull/321.

* Update for the IRC channel move from freenode to libera.chat.

examples:

* quest: Don't enable spelling correction by default.  It was really only on by
  default because the spelling correction support in quest was added before
  --flags.  It seems more helpful for the default to match the
  Xapian::QueryParser API, and also this fixes the weird situation that
  `--flags default` isn't the default you get without any `--flags` option.

* quest: Multiple `--flags` options now get combined - previously only the last
  was used.

portability:

* Don't automatically use _FORTIFY_SOURCE on mingw-w64.  Recent mingw-w64
  versions require -lssp to be linked when _FORTIFY_SOURCE is enabled, so just
  skip the automatic enabling.  Users who want to enable it can specify it
  explicitly.

  Fixes #808, reported by xpbxf4.

* Workaround NFS issue in test harness function for deleting test databases.
  On NFS, rmdir() can fail with EEXIST or ENOTEMPTY (POSIX allows either)
  due to .nfs* files which are used by NFS clients to implement the Unix
  semantics of a deleted but open file continuing to exist.  We now sleep
  and retry a few times in this situation to give the NFS client a chance
  to process the closing of the open handle.  Problem mentioned in #631.

* configure: Drop -lm special case for Sun C++ as this no longer seems to
  be required.  Tested with Sun C++ 5.13, which is the oldest version we
  now support due to us now requiring C++11.

* Use strerrordesc_np() if available. This is a GNU-specific replacement for
  sys_errlist and sys_nerr.  It was added in glibc 2.32 since which sys_errlist
  and sys_nerr are no longer declared in the headers.

* Update debug logging to use std::uncaught_exceptions() under C++17 and later
  since this allows the debug logging to detect a function without RETURN()
  annotation which exits normally while there's an uncaught exception
  (previously the debug logging would think the stack was being unwound through
  the function).  This also avoids deprecation warnings - the old
  std::uncaught_exception() (note: singular) function was deprecated by
  C++17 and removed in C++20.

* Increase size of buffer passed to strerror_r() from 128 to 1024 bytes, which
  is the size recommended by the man page on Linux.

* Fix -Wdeprecated-copy warning from clang 13.


To generate a diff of this commit:
cvs rdiff -u -r1.14 -r1.15 pkgsrc/textproc/xapian/Makefile.common
cvs rdiff -u -r1.44 -r1.45 pkgsrc/textproc/xapian/distinfo

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

Modified files:

Index: pkgsrc/textproc/xapian/Makefile.common
diff -u pkgsrc/textproc/xapian/Makefile.common:1.14 pkgsrc/textproc/xapian/Makefile.common:1.15
--- pkgsrc/textproc/xapian/Makefile.common:1.14 Thu Jan 14 18:17:09 2021
+++ pkgsrc/textproc/xapian/Makefile.common      Sun Jan  2 09:31:20 2022
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile.common,v 1.14 2021/01/14 18:17:09 schmonz Exp $
+# $NetBSD: Makefile.common,v 1.15 2022/01/02 09:31:20 schmonz Exp $
 # used by textproc/csharp-xapian/Makefile
 # used by textproc/lua-xapian/Makefile
 # used by textproc/p5-Xapian/Makefile
@@ -9,7 +9,7 @@
 # used by textproc/xapian/Makefile
 # used by textproc/xapian-omega/Makefile
 
-VERSION=               1.4.18
+VERSION=               1.4.19
 CATEGORIES=            textproc
 MASTER_SITES=          http://oligarchy.co.uk/xapian/${VERSION}/
 EXTRACT_SUFX=          .tar.xz

Index: pkgsrc/textproc/xapian/distinfo
diff -u pkgsrc/textproc/xapian/distinfo:1.44 pkgsrc/textproc/xapian/distinfo:1.45
--- pkgsrc/textproc/xapian/distinfo:1.44        Tue Oct 26 11:23:39 2021
+++ pkgsrc/textproc/xapian/distinfo     Sun Jan  2 09:31:20 2022
@@ -1,8 +1,8 @@
-$NetBSD: distinfo,v 1.44 2021/10/26 11:23:39 nia Exp $
+$NetBSD: distinfo,v 1.45 2022/01/02 09:31:20 schmonz Exp $
 
-BLAKE2s (xapian-core-1.4.18.tar.xz) = 9f83ec059956cf2a107e761642e1fbaa4dbc3c5505e59518a5c4e5e8d66cc454
-SHA512 (xapian-core-1.4.18.tar.xz) = ba6240054c0d2f92b9f1059aa934cdf35388ee7c7e05f4ef6f9856bdaed8ad821095a348ed9a892afdf18c3c0ad20e163028ad0ed3a9934bd69b861e814678ef
-Size (xapian-core-1.4.18.tar.xz) = 2984508 bytes
+BLAKE2s (xapian-core-1.4.19.tar.xz) = 2e8b02d4d67f4923268f1eabf7627c69c50d05aca37ef61cb1dd6f6bfa8057bc
+SHA512 (xapian-core-1.4.19.tar.xz) = d596058d7f9bfa0b73c5b6354331a799936b45f27012894f6792872ade8656bb0387b504aea8c1c3edfbd48787190452e7a49d2b62d181cb050c46edd3e67346
+Size (xapian-core-1.4.19.tar.xz) = 2994860 bytes
 SHA1 (patch-common_errno__to__string.cc) = 222b640aa1cdacb6f9ada78671ef414b4ca11e26
 SHA1 (patch-common_safesyssocket.h) = 032d441853914d510bc285bb682a98c4ee264d52
 SHA1 (patch-xapian-config.in) = 470d1de7f04b8b8817abbcf56b5b71a36948de97