Re: CVS commit: pkgsrc/games

[nia <nia%NetBSD.org@localhost>]

On Thu, Nov 18, 2021 at 04:36:05PM +0000, Patrick Welche wrote:
> On Thu, Nov 18, 2021 at 04:28:17PM +0000, nia wrote:
> > On Thu, Nov 18, 2021 at 05:17:02PM +0100, Joerg Sonnenberger wrote:
> > > On Thu, Nov 18, 2021 at 02:45:37PM +0000, Nia Alarie wrote:
> > > > Module Name:    pkgsrc
> > > > Committed By:   nia
> > > > Date:           Thu Nov 18 14:45:37 UTC 2021
> > > > 
> > > > Modified Files:
> > > >         pkgsrc/games/assaultcube: Makefile
> > > >         pkgsrc/games/redeclipse: Makefile
> > > >         pkgsrc/games/sauerbraten: Makefile
> > > > 
> > > > Log Message:
> > > > games: Mark the Cube 2 engine games as unsupported by RELRO
> > > > 
> > > > Unfortunately they use precompiled headers with GCC in a way that
> > > > would be very difficult to disable.
> > > 
> > > This commit doesn't make sense. How is PCH related to RELRO?!
> > > 
> > > Joerg
> > 
> > GCC's stupid way of dealing with PCH causes compilation failures if
> > any extra linker flags are forced through. Obviously I would like
> > to restrict this flag to GCC but unfortunately there's a circular
> > dependency on disabling RELRO and including bsd.prefs.mk.
> 
> How about the PRE vs AP - PENDING question?
> 
> 
> P

I missed the question, but I think it doesn't make a difference?

Here's a test case for some GCC behavior:

$ gcc -v
[works, exits successfully]
$ gcc -v -Wl,-znorelro -Wl,-zrelro
[relro appended, norelro in LDFLAGS, fails with a linker error]
$ gcc -Wl,-zrelro -v -Wl,-znorelro
[relro prepended, norelro in LDFLAGS, fails with a linker error]