I would like to understand the objections for $ORIGIN compared to setting LD_LIBRARY_PATH which is in my opinion strictly worse. The java build which uses LD_LIBRARY_PATH for bootstrap works only by accident, since it forces LD_LIBRARY_PATH on the bootstrap jdk which is not appropriate (for example it does not work when you try to bootstrap using a linux jdk, and it requires all the jdk binaries to be wrapped. The cwrappers code is a mess; there is a lot of code duplication, and it is not clear (to me) how and where are options processed. Using $ORIGIN simplifies the build and allows the jdk to work from any directory without using LD_LIBRARY_PATH which is the whole point. I committed the change to isabs() separately to demonstrate how small is the change to allow $ORIGIN. christos > On Nov 7, 2021, at 3:53 PM, Joerg Sonnenberger <joerg%bec.de@localhost> wrote: > > On Sun, Nov 07, 2021 at 03:28:40PM -0500, Christos Zoulas wrote: >> The point is now we control what gets passed and what gets eaten centrally, >> so that the patch to allow $ORIGIN now becomes the attached... > > Except that it is wrong because it applies to a variety of other options > beside rpath. Ignoring of course the still existing objection to $ORIGIN > use. > > Joerg
Attachment:
signature.asc
Description: Message signed with OpenPGP