Joerg Sonnenberger <joerg%bec.de@localhost> writes: > On Tue, Sep 07, 2021 at 02:00:52PM +0000, Greg Troxel wrote: >> Module Name: pkgsrc >> Committed By: gdt >> Date: Tue Sep 7 14:00:52 UTC 2021 >> >> Modified Files: >> pkgsrc/net/tor: Makefile >> >> Log Message: >> net/tor: Workaround upstream "micro-revision.i" bug >> >> There is something wrong in tor's makefiles which causes: >> >> src/lib/version/git_revision.c:21:10: fatal error: micro-revision.i: No such file or directory >> #include "micro-revision.i" >> ^~~~~~~~~~~~~~~~~~ >> compilation terminated. >> >> obviously by not having built micro-revision.i when that compilation >> is done. This happens reliably for some people and not for others. > > What about adding an explicit dependency for git_revision.c or other > files that include it on micro-revision.i? Could be done, certainly. I was trying to make the minimal change with lowest odds of causing trouble, until upstream (whose bug is open) fixes this correctly. https://gitlab.torproject.org/tpo/core/tor/-/issues/29520 Earlier I stared at the makefiles for a while trying to understand why this was not happening, because I think there is code that tries to do it already. Now, I only remember that I spent maybe an hour trying to figure it out and that I did not figure it out. If you figure it out and want to change it, I don't have a problem with that. I just didn't want to be responsible for breaking tor just before the branch.
Attachment:
signature.asc
Description: PGP signature