pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/sysutils/neb-wipe



Thomas Klausner <wiz%NetBSD.org@localhost> writes:

> On Fri, Aug 13, 2021 at 12:38:25PM -0400, Greg Troxel wrote:
>> 
>> Thomas Klausner <wiz%NetBSD.org@localhost> writes:
>> 
>> > On Fri, Aug 13, 2021 at 02:42:23PM +0000, David Brownlee wrote:
>> >> Module Name:      pkgsrc
>> >> Committed By:     abs
>> >> Date:             Fri Aug 13 14:42:23 UTC 2021
>> >> 
>> >> Modified Files:
>> >>   pkgsrc/sysutils/neb-wipe: Makefile
>> >> 
>> >> Log Message:
>> >> Note RELRO_SUPPORTED=no
>> >
>> > Don't do this -- just fix the build to honor LDFLAGS instead.
>> > I've done it for this package.
>> 
>> While it's better to fix things, if there's any discussion of turning on
>> flags by default, I think it's entirely valid to just mark things
>> unsupported, as that keeps the package from breaking as the default
>> changes.  (Certainly anyone who is able to fix it right and wants to can
>> do so, and glad you did.)
>
> I understand what you mean, but I think setting this flag should be a
> last resort after trying to fix the problem. Because once this flag is
> set, the probability that someone else will try to fix this is very
> low, since the breakage/problem is hidden.
>
> And since the default is still not switched, I think it's much too
> early to give up on packages in this way.

Given the way pkgsrc tends to go, I see a credible threat to change it
as saying it's time.  If we've made a decision that changing the
defaults will not happen until after Q3, then I see your point.

But, I gather nia@ is doing bulk builds and addressing things, which is
great.

Attachment: signature.asc
Description: PGP signature



Home | Main Index | Thread Index | Old Index