Re: CVS commit: pkgsrc/x11/fltk13

["Dr. Thomas Orgis" <thomas.orgis%uni-hamburg.de@localhost>]

Am Wed, 26 May 2021 16:38:50 +0200
schrieb Michael Bäuerle <micha%NetBSD.org@localhost>: 

> I tend to not remove this check (and add the tool dependency), because
> nobody has complained in the past.

So that would be

USE_TOOLS+= xprop:build

? And I see that pkg-config is missing. Shouldn't that be in USE_TOOLS,
too? Some packages have it … way more are using it, I suppose.

> Maybe someone else with deeper X11 knowledge can give a better advice.

My Intel graphics Linux doesn't have this. I found a description
for the nvidia proprietary driver:

Option "Overlay" "boolean"

    Enables RGB workstation overlay visuals. This is only supported on
    NVIDIA RTX/Quadro GPUs (Quadro NVS GPUs excluded) in depth 24. This
    option causes the server to advertise the SERVER_OVERLAY_VISUALS
    root window property and GLX will report single- and
    double-buffered, Z-buffered 16-bit overlay visuals. The
    transparency key is pixel 0x0000 (hex). There is no gamma
    correction support in the overlay plane. RGB workstation overlays
    are not supported when the Composite extension is enabled.

    UBB must be enabled when overlays are enabled (this is the default behavior).

I also see a reference in the Xsgi driver.

It might be not that common and probably outdated. But I see this in
the package:

CONFIGURE_ARGS+=        ac_cv_have_overlay=yes

$ grep OVERLA config.h
 * HAVE_OVERLAY:
#define HAVE_OVERLAY 1
 * HAVE_GL_OVERLAY:
#define HAVE_GL_OVERLAY HAVE_OVERLAY

So we got that covered anyway. It's unconditionally enabled. I guess
xprop can be ignored, then?

Current patch attached. Fine to commit?


Alrighty then,

Thomas

-- 
Dr. Thomas Orgis
HPC @ Universität Hamburg

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/x11/fltk13/Makefile,v
retrieving revision 1.39
diff -u -r1.39 Makefile
--- Makefile    26 May 2021 13:03:40 -0000      1.39
+++ Makefile    28 May 2021 07:03:38 -0000
@@ -15,7 +15,7 @@
 WRKSRC=                        ${WRKDIR}/${DISTNAME:S/-source//}
 USE_LANGUAGES=         c c++
 USE_LIBTOOL=           yes
-USE_TOOLS+=            gmake nroff
+USE_TOOLS+=            gmake nroff pkg-config
 TEST_TARGET=           test
 
 PKG_OPTIONS_VAR=       PKG_OPTIONS.fltk13
@@ -68,6 +68,10 @@
 .  include "../../x11/libXext/buildlink3.mk"
 .  include "../../x11/libXft/buildlink3.mk"
 .  include "../../x11/libXinerama/buildlink3.mk"
+.  include "../../fonts/fontconfig/buildlink3.mk"
+.  include "../../x11/libX11/buildlink3.mk"
+.  include "../../x11/libXrender/buildlink3.mk"
+.  include "../../x11/libXfixes/buildlink3.mk"
 BUILDLINK_DEPMETHOD.libXt?=    build
 .  include "../../x11/libXt/buildlink3.mk"
 .endif
Index: buildlink3.mk
===================================================================
RCS file: /cvsroot/pkgsrc/x11/fltk13/buildlink3.mk,v
retrieving revision 1.16
diff -u -r1.16 buildlink3.mk
--- buildlink3.mk       17 Aug 2020 20:17:49 -0000      1.16
+++ buildlink3.mk       28 May 2021 07:03:38 -0000
@@ -26,6 +26,10 @@
 .  include "../../x11/libXext/buildlink3.mk"
 .  include "../../x11/libXft/buildlink3.mk"
 .  include "../../x11/libXinerama/buildlink3.mk"
+.  include "../../fonts/fontconfig/buildlink3.mk"
+.  include "../../x11/libX11/buildlink3.mk"
+.  include "../../x11/libXrender/buildlink3.mk"
+.  include "../../x11/libXfixes/buildlink3.mk"
 .endif
 .include "../../mk/jpeg.buildlink3.mk"
 .include "../../graphics/png/buildlink3.mk"