On 07.11.2020 11:05, Nia Alarie wrote: > Module Name: pkgsrc > Committed By: nia > Date: Sat Nov 7 10:05:12 UTC 2020 > > Modified Files: > pkgsrc/x11/vte3: Makefile > Added Files: > pkgsrc/x11/vte3: options.mk > > Log Message: > vte3: Make icu support optional. > > According to upstream it's only used for legacy charset support, and > doesn't seem to be enabled in some popular Linux distributions I checked. > At least in Debian and Fedora (and thus assumed descendants) vte3 ships with enabled ICU support. https://packages.debian.org/sid/libvte-2.91-dev https://src.fedoraproject.org/rpms/vte291/blob/master/f/vte291.spec Disabled ICU breaks Gnome Terminator https://github.com/gnome-terminator/terminator (packaged as py-terminator, I have got a local upgrade to 2.1.0). $ terminator Unable to load Keybinder module. This means the hide_window shortcut will be unavailable Unable to bind hide_window key, another instance/window has it. error loading background image: g-file-error-quark: Failed to open file “None”: No such file or directory (4) PluginRegistry::load_plugins: Importing plugin LayoutManager.py failed: When using gi.repository you must not import static modules like "gobject". Please change all occurrences of "import gobject" to "from gi.repository import GObject". See: https://bugzilla.gnome.org/show_bug.cgi?id=709183 Traceback (most recent call last): File "/usr/pkg/bin/terminator", line 129, in <module> TERMINATOR.create_layout(OPTIONS.layout) File "/usr/pkg/lib/python3.8/site-packages/terminatorlib/terminator.py", line 285, in create_layout window, terminal = self.new_window() File "/usr/pkg/lib/python3.8/site-packages/terminatorlib/terminator.py", line 208, in new_window terminal = maker.make('Terminal') File "/usr/pkg/lib/python3.8/site-packages/terminatorlib/factory.py", line 93, in make output = func(**kwargs) File "/usr/pkg/lib/python3.8/site-packages/terminatorlib/factory.py", line 105, in make_terminal return(terminal.Terminal()) File "/usr/pkg/lib/python3.8/site-packages/terminatorlib/terminal.py", line 226, in __init__ self.reconfigure() File "/usr/pkg/lib/python3.8/site-packages/terminatorlib/terminal.py", line 689, in reconfigure self.vte.set_encoding(self.config['encoding']) gi.repository.GLib.Error: g_convert_error: ICU support not available (0) This patch unbreaks the terminal emulator for me, by the inclusion of icu option by default (and thus making it usable for binary package users): http://netbsd.org/~kamil/patch-00289-vte3-icu.txt I plan to commit it in a few days. Gnome Terminator is a popular package and has >500 stars on GitHub. I use it as my daily driver for years now.
Attachment:
signature.asc
Description: OpenPGP digital signature