pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/mk/platform



On 02.06.2020 18:22, Jonathan Perkin wrote:
Module Name:    pkgsrc
Committed By:   jperkin
Date:           Tue Jun  2 16:22:40 UTC 2020

Modified Files:
        pkgsrc/mk/platform: SunOS.mk

Log Message:
mk: bmake cannot compare non-integers numerically.

It can. It just interprets them as (arithmetic) numbers, not (version)
numbers. Therefore 5.10 == 5.1 == 5.10000000.

Unfortunately, "String comparison operator should be either == or !="
(devel/bmake/files/cond.c), therefore it doesn't work if you enclose the
right-hand side in quotes.  The details are in devel/bmake/files/cond.c,
function compare_expression.

-.if ${OS_VERSION} >= 5.10
+.if empty(OS_VERSION:M5.[0-9])

Not bad, this bug survived for 6 years.  I had expected it to be found
faster.



Home | Main Index | Thread Index | Old Index