Re: CVS commit: pkgsrc/multimedia/mpv

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Hello Ryo,

Ryo ONODERA writes:
> [...]
> Log Message:
> mpv: Add libossaudio to fix build under recent NetBSD-current
> [...]

Thanks for adding that but I think that could be still problematic for
other platforms.  Possible more general patch directly inline.

> Index: pkgsrc/multimedia/mpv/Makefile
> diff -u pkgsrc/multimedia/mpv/Makefile:1.104 pkgsrc/multimedia/mpv/Makefile:1.105
> --- pkgsrc/multimedia/mpv/Makefile:1.104      Wed Mar 18 11:49:21 2020
> +++ pkgsrc/multimedia/mpv/Makefile    Tue Apr  7 13:47:04 2020
> [...]
> @@ -70,6 +70,7 @@ post-install:
>  
>  .include "options.mk"
>  
> +LDFLAGS.NetBSD+=     -lossaudio
> [...]

Instead of LDFLAGS.NetBSD I think it should be used:

 LDFLAGS+=      ${LIBOSSAUDIO}


Can you please test and if that works and you agree commit this
possible - and more general - version?
Thanks!