pkgsrc-Changes archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: CVS commit: pkgsrc/databases



Le 2019-10-24 12:57, Leonardo Taccari a écrit :
Frédéric Fauberteau writes:
Le 2019-10-24 10:07, Leonardo Taccari a écrit :
> [...]
>> postgresql12: make nls support optional
>> [...]
>
> Given that the default options are changed that would need a
> PKGREVISION
> bump to all packages too.  Can you please bump PKGREVISION to them?
>
[...]

I read doc/pkgsrc.txt and a change in PLIST is indicated as a reason to
bump revision. I was gone to do it. But I asked to Adam who is the
maintainer and he wouldn't because that does not change any binary
files. And he is right.

I let you discuss for the final word.
[...]

The guide says `[...] PKGREVISION should be incremented for any
non-trivial change in the resulting binary package. [...]'.
If I am not missing something after this change all files marked in the
PLIST.nls are no longer installed and that would be a change in the
resulting binary package (also if the "binary files" are not changed the
resulting binary package is changed).

Okay, but `Please only commit changes that adam%NetBSD.org@localhost would approve`.



Home | Main Index | Thread Index | Old Index